comparison tests/test-phabricator.t @ 44436:09f3e003fc2a

phabricator: avoid a stacktrace when command arguments are missing

Previously, the TypeError wasn't properly converted to a SignatureError when
improper arguments were supplied to the inner function, because the stack depth
is 2 inside the vcrcommand decorator.  The `__name__` and `__doc__` attributes
need to be reassigned to the new wrapper so that the help summary is available.

Differential Revision: https://phab.mercurial-scm.org/D8209

44435:4152183acedd

above config and have a real token in the test but not have to edit
this test.
  $ hg phabread --config auth.hgphab.phabtoken=cli-notavalidtoken \
  >  --test-vcr "$VCR/phabread-conduit-error.json" D4480 | head
  abort: Conduit Error (ERR-INVALID-AUTH): API token "cli-notavalidtoken" has the wrong length. API tokens should be 32 characters long.

Basic phabread:
  $ hg phabread --test-vcr "$VCR/phabread-4480.json" D4480 | head
  # HG changeset patch
  # Date 1536771503 0

44436:09f3e003fc2a

above config and have a real token in the test but not have to edit
this test.
  $ hg phabread --config auth.hgphab.phabtoken=cli-notavalidtoken \
  >  --test-vcr "$VCR/phabread-conduit-error.json" D4480 | head
  abort: Conduit Error (ERR-INVALID-AUTH): API token "cli-notavalidtoken" has the wrong length. API tokens should be 32 characters long.

Missing arguments print the command help

  $ hg phabread
  hg phabread: invalid arguments
  hg phabread DREVSPEC [OPTIONS]
  
  print patches from Phabricator suitable for importing
  
  options:
  
    --stack read dependencies
  
  (use 'hg phabread -h' to show more help)
  [255]

Basic phabread:
  $ hg phabread --test-vcr "$VCR/phabread-4480.json" D4480 | head
  # HG changeset patch
  # Date 1536771503 0