comparison mercurial/wireprotoserver.py @ 36800:0b18604db95e

wireproto: declare permissions requirements in @wireprotocommand (API)

With the security patches from 4.5.2 merged into default, we now
have a per-command attribute defining what permissions are needed
to run that command. We now have a richer @wireprotocommand that
can be extended to record additional command metadata. So we
port the permissions mechanism to be based on @wireprotocommand.

.. api::

   hgweb_mod.perms and wireproto.permissions have been removed. Wire
   protocol commands should declare their required permissions in the
   @wireprotocommand decorator.

Differential Revision: https://phab.mercurial-scm.org/D2718

36799:c638a13093cf

        req.respond(HTTP_OK, HGERRTYPE,
                    body=_('requested wire protocol command is not available '
                           'over HTTP'))
        return []

    # Assume commands with no defined permissions are writes /
    # for pushes. This is the safest from a security perspective
    # because it doesn't allow commands with undefined semantics
    # from bypassing permissions checks.
    checkperm(wireproto.permissions.get(cmd, 'push'))

    rsp = wireproto.dispatch(repo, proto, cmd)

    if isinstance(rsp, bytes):
        req.respond(HTTP_OK, HGTYPE, body=rsp)

36800:0b18604db95e

        req.respond(HTTP_OK, HGERRTYPE,
                    body=_('requested wire protocol command is not available '
                           'over HTTP'))
        return []

    checkperm(wireproto.commands[cmd].permission)

    rsp = wireproto.dispatch(repo, proto, cmd)

    if isinstance(rsp, bytes):
        req.respond(HTTP_OK, HGTYPE, body=rsp)