comparison rust/hg-cpython/src/revlog.rs @ 52180:1032bb0ef365

rust-revlog: build an in-memory nodemap if a given revlog gets queried a lot

This will help with non-persistent nodemap repos that would benefit from
one, and mirrors what the C implementation does.

52179:c90e0f65896e

    NULL_REVISION,
};
use std::{
    cell::{Cell, RefCell},
    collections::{HashMap, HashSet},
    sync::atomic::{AtomicBool, Ordering},
    sync::OnceLock,
};
use vcsgraph::graph::Graph as VCSGraph;

pub struct PySharedIndex {

    data index_mmap: RefCell<PyBuffer>;
    data head_revs_py_list: RefCell<Option<PyList>>;
    data head_node_ids_py_list: RefCell<Option<PyList>>;
    data revision_cache: RefCell<Option<PyObject>>;
    data use_persistent_nodemap: bool;

    def __new__(
        _cls,
        vfs_base: PyObject,
        fncache: PyObject,

    def clear_cache(&self) -> PyResult<PyObject> {
        assert!(!self.is_delaying(py)?);
        self.revision_cache(py).borrow_mut().take();
        self.inner(py).borrow_mut().clear_cache();
        Ok(py.None())
    }

    @property def canonical_index_file(&self) -> PyResult<PyBytes> {
        let path = self.inner(py).borrow().canonical_index_file();

        let node = node_from_py_bytes(py, &node)?;
        // Filelogs have no persistent nodemaps and are often small, use a
        // brute force lookup from the end backwards. If there is a very large
        // filelog (automation file that changes every commit etc.), it also
        // seems to work quite well for all measured purposes so far.
        //
        // TODO build an in-memory nodemap if more than 4 queries to the same
        // revlog are made?
        if !*self.use_persistent_nodemap(py) {
            let idx = &self.inner(py).borrow().index;
            let res =
                idx.rev_from_node_no_persistent_nodemap(node.into()).ok();
            return Ok(res.map(Into::into))
        }

            RefCell::new(buf),
            RefCell::new(None),
            RefCell::new(None),
            RefCell::new(None),
            use_persistent_nodemap,
        )
    }
}

py_class!(pub class NodeTree |py| {

52180:1032bb0ef365

    NULL_REVISION,
};
use std::{
    cell::{Cell, RefCell},
    collections::{HashMap, HashSet},
    sync::atomic::{AtomicBool, AtomicUsize, Ordering},
    sync::OnceLock,
};
use vcsgraph::graph::Graph as VCSGraph;

pub struct PySharedIndex {

    data index_mmap: RefCell<PyBuffer>;
    data head_revs_py_list: RefCell<Option<PyList>>;
    data head_node_ids_py_list: RefCell<Option<PyList>>;
    data revision_cache: RefCell<Option<PyObject>>;
    data use_persistent_nodemap: bool;
    data nodemap_queries: AtomicUsize;

    def __new__(
        _cls,
        vfs_base: PyObject,
        fncache: PyObject,

    def clear_cache(&self) -> PyResult<PyObject> {
        assert!(!self.is_delaying(py)?);
        self.revision_cache(py).borrow_mut().take();
        self.inner(py).borrow_mut().clear_cache();
        self.nodemap_queries(py).store(0, Ordering::Relaxed);
        Ok(py.None())
    }

    @property def canonical_index_file(&self) -> PyResult<PyBytes> {
        let path = self.inner(py).borrow().canonical_index_file();

        let node = node_from_py_bytes(py, &node)?;
        // Filelogs have no persistent nodemaps and are often small, use a
        // brute force lookup from the end backwards. If there is a very large
        // filelog (automation file that changes every commit etc.), it also
        // seems to work quite well for all measured purposes so far.
        let mut nodemap_queries =
            self.nodemap_queries(py).fetch_add(1, Ordering::Relaxed);
        // Still need to add since `fetch_add` returns the old value
        nodemap_queries += 1;
        if !*self.use_persistent_nodemap(py) && nodemap_queries <= 4 {
            let idx = &self.inner(py).borrow().index;
            let res =
                idx.rev_from_node_no_persistent_nodemap(node.into()).ok();
            return Ok(res.map(Into::into))
        }

            RefCell::new(buf),
            RefCell::new(None),
            RefCell::new(None),
            RefCell::new(None),
            use_persistent_nodemap,
            AtomicUsize::new(0),
        )
    }
}

py_class!(pub class NodeTree |py| {