comparison mercurial/bookmarks.py @ 17917:12178f07de97

bookmark: issue a single call to `allsuccessors` per loop

Update to this code was minimalist when `allsuccessors` argument were changed
from a list to a set. As this code is getting my attention again I realised we
can drastically simplify this part of the code by issue a single call to
`allsuccessors`.

17916:ed225834b372

        plen = -1
        # compute the whole set of successors or descendants
        while len(validdests) != plen:
            plen = len(validdests)
            succs = set(c.node() for c in validdests)
            for c in validdests:
                if c.mutable():
                    # obsolescence marker does not apply to public changeset
                    succs.update(obsolete.allsuccessors(repo.obsstore,
                                                        [c.node()]))
            known = (n for n in succs if n in nm)
            validdests = set(repo.set('%ln::', known))
        validdests.remove(old)
        return new in validdests
    else:

17917:12178f07de97

        plen = -1
        # compute the whole set of successors or descendants
        while len(validdests) != plen:
            plen = len(validdests)
            succs = set(c.node() for c in validdests)
            mutable = [c.node() for c in validdests if c.mutable()]
            succs.update(obsolete.allsuccessors(repo.obsstore, mutable))
            known = (n for n in succs if n in nm)
            validdests = set(repo.set('%ln::', known))
        validdests.remove(old)
        return new in validdests
    else: