Mercurial > hg
comparison tests/check-perf-code.py @ 30146:148ccd1d9f2f
perf: add functions to get vfs-like object for Mercurial earlier than 2.3
Before this patch, using svfs prevents perf.py from measuring
performance of Mercurial earlier than 2.3 (or 7034365089bf), because
svfs isn't available in such Mercurial, even though there are some
code paths for Mercurial earlier than 2.3 in perf.py.
For example, setting "_prereadsize" attribute in perfindex() and
perfnodelookup() is effective only with hg earlier than 1.8 (or
61c9bc3da402).
To get appropriate vfs-like object to access files under .hg/store,
this patch adds getsvfs() (and also getvfs(), for future use).
To avoid examining existence of attribute at each repetition while
measuring performance, getsvfs() is invoked outside the function to be
called repeatedly.
This patch also adds check-perf-code.py an extra check entry to detect
direct usage of repo.(vfs|svfs|opener|sopener) in perf.py.
author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
---|---|
date | Sun, 09 Oct 2016 01:03:18 +0900 |
parents | 14031d183048 |
children | d8a2c536dd96 |
comparison
equal
deleted
inserted
replaced
30145:113aa6145020 | 30146:148ccd1d9f2f |
---|---|
10 # write static check patterns here | 10 # write static check patterns here |
11 perfpypats = [ | 11 perfpypats = [ |
12 [ | 12 [ |
13 (r'(branchmap|repoview)\.subsettable', | 13 (r'(branchmap|repoview)\.subsettable', |
14 "use getbranchmapsubsettable() for early Mercurial"), | 14 "use getbranchmapsubsettable() for early Mercurial"), |
15 (r'\.(vfs|svfs|opener|sopener)', | |
16 "use getvfs()/getsvfs() for early Mercurial"), | |
15 ], | 17 ], |
16 # warnings | 18 # warnings |
17 [ | 19 [ |
18 ] | 20 ] |
19 ] | 21 ] |