comparison mercurial/manifest.py @ 39869:14e500b58263

revlog: add method for obtaining storage info (API) We currently have a handful of methods on the file and manifest storage interfaces for obtaining metadata about storage. e.g. files() is used to obtain the files backing storage. rawsize() is to quickly compute the size of tracked revisions without resolving their fulltext. Code in upgrade and stream clone make heavy use of these methods. The existing APIs are generic and don't necessarily have the specialization that we need going forward. For example, files() doesn't distinguish between exclusive storage and shared storage. This makes stream clone difficult to implement when e.g. there may be a single file backing storage for multiple tracked paths. It also makes reporting difficult, as we don't know how many bytes are actually used by storage since we can't easily identify shared files. This commit implements a new method for obtaining storage metadata. It is designed to accept arguments specifying what metadata to request and to return a dict with those fields populated. We /could/ make each of these attributes a separate method. But this is a specialized API and I'm trying to avoid method bloat on the interfaces. There is also the possibility that certain callers will want to obtain multiple fields in different combinations and some backends may have performance issues obtaining all that data via separate method calls. Simple storage integration tests have been added. For now, we assume fields can't be "None" (ignoring the interface documentation). We can revisit this later. Differential Revision: https://phab.mercurial-scm.org/D4747
author Gregory Szorc <gregory.szorc@gmail.com>
date Mon, 24 Sep 2018 11:56:48 -0700
parents e23c03dc5cf9
children da0319e024c0
comparison
equal deleted inserted replaced
39868:b06303a208be 39869:14e500b58263
1590 if not isinstance(destrevlog, manifestrevlog): 1590 if not isinstance(destrevlog, manifestrevlog):
1591 raise error.ProgrammingError('expected manifestrevlog to clone()') 1591 raise error.ProgrammingError('expected manifestrevlog to clone()')
1592 1592
1593 return self._revlog.clone(tr, destrevlog._revlog, **kwargs) 1593 return self._revlog.clone(tr, destrevlog._revlog, **kwargs)
1594 1594
1595 def storageinfo(self, exclusivefiles=False, sharedfiles=False,
1596 revisionscount=False, trackedsize=False,
1597 storedsize=False):
1598 return self._revlog.storageinfo(
1599 exclusivefiles=exclusivefiles, sharedfiles=sharedfiles,
1600 revisionscount=revisionscount, trackedsize=trackedsize,
1601 storedsize=storedsize)
1602
1595 @property 1603 @property
1596 def indexfile(self): 1604 def indexfile(self):
1597 return self._revlog.indexfile 1605 return self._revlog.indexfile
1598 1606
1599 @indexfile.setter 1607 @indexfile.setter