Mercurial > hg
comparison tests/run-tests.py @ 42386:15d5a2de44aa
tests: make run-tests exit non-zero if there are "errors"
Previously, if there was an error such as a broken .t file that caused
run-tests.py to encounter an exception during parsing, the test would be
considered in an "errored" state, which is separate from "failed".
The check for whether to exit non-zero or not was based entirely on whether
there were any tests in a "failed" state, so if there was only an error,
run-tests would exit with 0. Our test infrastructure would then consider the
test as passing, causing us to have some tests with false negatives that have
gone undetected for a few weeks now.
Differential Revision: https://phab.mercurial-scm.org/D6452
author | Kyle Lippincott <spectral@google.com> |
---|---|
date | Tue, 28 May 2019 23:22:46 -0700 |
parents | 4cbccb50df46 |
children | ae3f862cbb3d |
comparison
equal
deleted
inserted
replaced
42385:21c436a3a4e8 | 42386:15d5a2de44aa |
---|---|
2910 log('running %d tests using %d parallel processes' % ( | 2910 log('running %d tests using %d parallel processes' % ( |
2911 num_tests, jobs)) | 2911 num_tests, jobs)) |
2912 | 2912 |
2913 result = runner.run(suite) | 2913 result = runner.run(suite) |
2914 | 2914 |
2915 if result.failures: | 2915 if result.failures or result.errors: |
2916 failed = True | 2916 failed = True |
2917 | 2917 |
2918 result.onEnd() | 2918 result.onEnd() |
2919 | 2919 |
2920 if self.options.anycoverage: | 2920 if self.options.anycoverage: |