comparison mercurial/shelve.py @ 46270:161313f9c467

shelve: rewrite check for unknown shelf to delete

The code would try to delete the shelf's .patch file and if that
raised an exception, it would convert it to an `error.Abort`. This
patch rewrites it so the check is done upfront. I find it easier to
read that way. It's now clear enough that I removed the comment
explaining it as well.

As Joerg pointed out during review, another differences is that the
old code would move a `.hg` file without its `.patch` friend to backup
before it realized that the `.patch` file was missing. The new code
will error out earlier and not move the `.hg` file, which seems like
an improvement. That should only matter on corrupt `.hg/shelved/`
directories, however.

Differential Revision: https://phab.mercurial-scm.org/D9697

46269:44556639f14a

    """subcommand that deletes a specific shelve"""
    if not pats:
        raise error.Abort(_(b'no shelved changes specified!'))
    with repo.wlock():
        for name in pats:
            try:
                for suffix in shelvefileextensions:
                    shfile = shelvedfile(repo, name, suffix)
                    # patch file is necessary, as it should
                    # be present for any kind of shelve,
                    # but the .hg file is optional as in future we
                    # will add obsolete shelve with does not create a
                    # bundle
                    if shfile.exists() or suffix == patchextension:
                        shfile.movetobackup()
            except OSError as err:
                if err.errno != errno.ENOENT:
                    raise
                raise error.Abort(_(b"shelved change '%s' not found") % name)
            cleanupoldbackups(repo)


def listshelves(repo):
    """return all shelves in repo as list of (time, filename)"""

46270:161313f9c467

    """subcommand that deletes a specific shelve"""
    if not pats:
        raise error.Abort(_(b'no shelved changes specified!'))
    with repo.wlock():
        for name in pats:
            if not shelvedfile(repo, name, patchextension).exists():
                raise error.Abort(_(b"shelved change '%s' not found") % name)
            for suffix in shelvefileextensions:
                shfile = shelvedfile(repo, name, suffix)
                if shfile.exists():
                    shfile.movetobackup()
            cleanupoldbackups(repo)


def listshelves(repo):
    """return all shelves in repo as list of (time, filename)"""