comparison mercurial/repoview.py @ 50772:1680ef94ad2b stable

repoview: fix the filter created by `extrafilter`

The `name` variable was updated in each interaction of the loop, making all new
filters inheriting from the same base (the last one iterated), leading to
terrible terrible misbehavior.

50771:d24573181003

    combine = lambda fname: fname + b'%' + fid

    subsettable = repoviewutil.subsettable

    if combine(b'base') not in filtertable:
        for name in _basefiltername:

            def extrafilteredrevs(repo, *args, **kwargs):
                baserevs = filtertable[name](repo, *args, **kwargs)
                extrarevs = frozenset(repo.revs(frevs))
                return baserevs | extrarevs

            filtertable[combine(name)] = extrafilteredrevs
            if name in subsettable:
                subsettable[combine(name)] = combine(subsettable[name])
    return fid


def filterrevs(repo, filtername, visibilityexceptions=None):
    """returns set of filtered revision for this filter name

50772:1680ef94ad2b

    combine = lambda fname: fname + b'%' + fid

    subsettable = repoviewutil.subsettable

    if combine(b'base') not in filtertable:
        for base_name in _basefiltername:

            def extrafilteredrevs(repo, *args, name=base_name, **kwargs):
                baserevs = filtertable[name](repo, *args, **kwargs)
                extrarevs = frozenset(repo.revs(frevs))
                return baserevs | extrarevs

            filtertable[combine(base_name)] = extrafilteredrevs
            if base_name in subsettable:
                subsettable[combine(base_name)] = combine(
                    subsettable[base_name]
                )
    return fid


def filterrevs(repo, filtername, visibilityexceptions=None):
    """returns set of filtered revision for this filter name