comparison hgext/extdiff.py @ 45400:1bed1b00b18d

extdiff: remove dir2root and pass full path as dir2 in _runperfilediff()

The only use of `dir2root` was to join with `dir2` to generate the path for
other side of diff. Like in previous patch, `dir1a` and `dir1b` are full paths
and no longer base names, hence we pass `dir2` as full path too and making
`dir2root` unrequired.

Differential Revision: https://phab.mercurial-scm.org/D8970

45399:e7c5735433ac

    confirm,
    commonfiles,
    tmproot,
    dir1a,
    dir1b,
    dir2root,
    dir2,
    rev1a,
    rev1b,
    rev2,
):

            path1b = os.path.join(dir1b, commonfile)
            label1b = commonfile + rev1b
            if not os.path.isfile(path1b):
                path1b = pycompat.osdevnull

        path2 = os.path.join(dir2root, dir2, commonfile)
        label2 = commonfile + rev2

        if confirm:
            # Prompt before showing this diff
            difffiles = _(b'diff %s (%d of %d)') % (

            confirm=opts.get(b'confirm'),
            commonfiles=common,
            tmproot=tmproot,
            dir1a=os.path.join(tmproot, dir1a),
            dir1b=os.path.join(tmproot, dir1b) if do3way else None,
            dir2root=dir2root,
            dir2=dir2,
            rev1a=rev1a,
            rev1b=rev1b,
            rev2=rev2,
        )

45400:1bed1b00b18d

    confirm,
    commonfiles,
    tmproot,
    dir1a,
    dir1b,
    dir2,
    rev1a,
    rev1b,
    rev2,
):

            path1b = os.path.join(dir1b, commonfile)
            label1b = commonfile + rev1b
            if not os.path.isfile(path1b):
                path1b = pycompat.osdevnull

        path2 = os.path.join(dir2, commonfile)
        label2 = commonfile + rev2

        if confirm:
            # Prompt before showing this diff
            difffiles = _(b'diff %s (%d of %d)') % (

            confirm=opts.get(b'confirm'),
            commonfiles=common,
            tmproot=tmproot,
            dir1a=os.path.join(tmproot, dir1a),
            dir1b=os.path.join(tmproot, dir1b) if do3way else None,
            dir2=os.path.join(dir2root, dir2),
            rev1a=rev1a,
            rev1b=rev1b,
            rev2=rev2,
        )