comparison mercurial/statichttprepo.py @ 44604:2141427533d2 stable

py3: require values in changelog extras to be bytes I don't know what happened here because b436059c1cca (py3: use pycompat.bytestr() on extra values because it can be int, 2019-02-05) came about b44a47214122 (py3: use string for "close" value in commit extras, 2018-02-11). Whatever happened, we shouldn't need to convert the values to bytes now. It's better to not convert because that might cover up bugs where someone sets a unicode value in the extras and that works until the unicode value happens to contain non-ascii (at which point it will fail because `bytestr()` expects its argument to be ascii if it's unicode). Differential Revision: https://phab.mercurial-scm.org/D8332
author Martin von Zweigbergk <martinvonz@google.com>
date Wed, 25 Mar 2020 18:50:40 -0700
parents 9f70512ae2cf
children 5523e3e1bc71
comparison
equal deleted inserted replaced
44603:bda050bc9987 44604:2141427533d2