comparison mercurial/bookmarks.py @ 48685:21ac6aedd5e5

transaction: do not rely on a global variable to post_finalize file

We can just add a new argument to the `addfilegenerator` function. This is more
explicit and therefor clearer and less error prone.

Differential Revision: https://phab.mercurial-scm.org/D12125

48684:568f63b5a30f

        """record that bookmarks have been changed in a transaction

        The transaction is then responsible for updating the file content."""
        location = b'' if bookmarksinstore(self._repo) else b'plain'
        tr.addfilegenerator(
            b'bookmarks', (b'bookmarks',), self._write, location=location
        )
        tr.hookargs[b'bookmark_moved'] = b'1'

    def _writerepo(self, repo):
        """Factored out for extensibility"""

48685:21ac6aedd5e5

        """record that bookmarks have been changed in a transaction

        The transaction is then responsible for updating the file content."""
        location = b'' if bookmarksinstore(self._repo) else b'plain'
        tr.addfilegenerator(
            b'bookmarks',
            (b'bookmarks',),
            self._write,
            location=location,
            post_finalize=True,
        )
        tr.hookargs[b'bookmark_moved'] = b'1'

    def _writerepo(self, repo):
        """Factored out for extensibility"""