comparison hgext/rebase.py @ 31514:2519994d25ca

rebase: use one dirstateguard for entire rebase

Recently we switched rebases to run the entire rebase inside a single
transaction, which dramatically improved the speed of rebases in repos with
large working copies. Let's also move the dirstate into a single dirstateguard
to get the same benefits. This let's us avoid serializing the dirstate after
each commit.

In a large repo, rebasing 27 commits is sped up by about 20%.

I believe the test changes are because us touching the dirstate gave the
transaction something to actually rollback.

31513:68474b72ea63

                       self.state[rebased] > nullmerge:
                        commitmsg += '\n* %s' % repo[rebased].description()
                editopt = True
            editor = cmdutil.getcommiteditor(edit=editopt, editform=editform)
            revtoreuse = max(self.state)
            newnode = concludenode(repo, revtoreuse, p1, self.external,
                                   commitmsg=commitmsg,
                                   extrafn=_makeextrafn(self.extrafns),
                                   editor=editor,
                                   keepbranches=self.keepbranchesf,
                                   date=self.date)
            if newnode is None:
                newrev = self.target
            else:
                newrev = repo[newnode].rev()
            for oldrev in self.state.iterkeys():

            retcode = rbsrt._preparenewrebase(dest, rebaseset)
            if retcode is not None:
                return retcode

        with repo.transaction('rebase') as tr:
            try:
                rbsrt._performrebase(tr)
            except error.InterventionRequired:
                tr.close()
                raise
        rbsrt._finishrebase()
    finally:
        release(lock, wlock)

def concludenode(repo, rev, p1, p2, commitmsg=None, editor=None, extrafn=None,
                 keepbranches=False, date=None):
    '''Commit the wd changes with parents p1 and p2. Reuse commit info from rev
    but also store useful information in extra.
    Return node of committed revision.'''
    dsguard = dirstateguard.dirstateguard(repo, 'rebase')
    try:
        repo.setparents(repo[p1].node(), repo[p2].node())
        ctx = repo[rev]
        if commitmsg is None:
            commitmsg = ctx.description()
        keepbranch = keepbranches and repo[p1].branch() != ctx.branch()
        extra = {'rebase_source': ctx.hex()}
        if extrafn:
            extrafn(ctx, extra)

        targetphase = max(ctx.phase(), phases.draft)
        overrides = {('phases', 'new-commit'): targetphase}
        with repo.ui.configoverride(overrides, 'rebase'):
            if keepbranch:
                repo.ui.setconfig('ui', 'allowemptycommit', True)
            # Commit might fail if unresolved files exist
            if date is None:
                date = ctx.date()
            newnode = repo.commit(text=commitmsg, user=ctx.user(),
                                  date=date, extra=extra, editor=editor)

        repo.dirstate.setbranch(repo[newnode].branch())
        dsguard.close()
        return newnode
    finally:
        release(dsguard)

def rebasenode(repo, rev, p1, base, state, collapse, target):
    'Rebase a single revision rev on top of p1 using base as merge ancestor'
    # Merge phase
    # Update to target and merge it with local

31514:2519994d25ca

                       self.state[rebased] > nullmerge:
                        commitmsg += '\n* %s' % repo[rebased].description()
                editopt = True
            editor = cmdutil.getcommiteditor(edit=editopt, editform=editform)
            revtoreuse = max(self.state)
            dsguard = dirstateguard.dirstateguard(repo, 'rebase')
            try:
                newnode = concludenode(repo, revtoreuse, p1, self.external,
                                       commitmsg=commitmsg,
                                       extrafn=_makeextrafn(self.extrafns),
                                       editor=editor,
                                       keepbranches=self.keepbranchesf,
                                       date=self.date)
                dsguard.close()
                release(dsguard)
            except error.InterventionRequired:
                dsguard.close()
                release(dsguard)
                raise
            except Exception:
                release(dsguard)
                raise

            if newnode is None:
                newrev = self.target
            else:
                newrev = repo[newnode].rev()
            for oldrev in self.state.iterkeys():

            retcode = rbsrt._preparenewrebase(dest, rebaseset)
            if retcode is not None:
                return retcode

        with repo.transaction('rebase') as tr:
            dsguard = dirstateguard.dirstateguard(repo, 'rebase')
            try:
                rbsrt._performrebase(tr)
                dsguard.close()
                release(dsguard)
            except error.InterventionRequired:
                dsguard.close()
                release(dsguard)
                tr.close()
                raise
            except Exception:
                release(dsguard)
                raise
        rbsrt._finishrebase()
    finally:
        release(lock, wlock)

def concludenode(repo, rev, p1, p2, commitmsg=None, editor=None, extrafn=None,
                 keepbranches=False, date=None):
    '''Commit the wd changes with parents p1 and p2. Reuse commit info from rev
    but also store useful information in extra.
    Return node of committed revision.'''
    repo.setparents(repo[p1].node(), repo[p2].node())
    ctx = repo[rev]
    if commitmsg is None:
        commitmsg = ctx.description()
    keepbranch = keepbranches and repo[p1].branch() != ctx.branch()
    extra = {'rebase_source': ctx.hex()}
    if extrafn:
        extrafn(ctx, extra)

    targetphase = max(ctx.phase(), phases.draft)
    overrides = {('phases', 'new-commit'): targetphase}
    with repo.ui.configoverride(overrides, 'rebase'):
        if keepbranch:
            repo.ui.setconfig('ui', 'allowemptycommit', True)
        # Commit might fail if unresolved files exist
        if date is None:
            date = ctx.date()
        newnode = repo.commit(text=commitmsg, user=ctx.user(),
                              date=date, extra=extra, editor=editor)

    repo.dirstate.setbranch(repo[newnode].branch())
    return newnode

def rebasenode(repo, rev, p1, base, state, collapse, target):
    'Rebase a single revision rev on top of p1 using base as merge ancestor'
    # Merge phase
    # Update to target and merge it with local