comparison mercurial/changegroup.py @ 42341:27d6956d386b

match: use '' instead of '.' for root directory (API)

I think '' is generally a better value for the root directory than '.'
is. For example, os.path.join('', 'foo') => 'foo', while
os.path.join('.', 'foo') => './foo'.

This patch mostly makes it so we use '' internally in
match.py. However, it also affects the API in visitdir(),
visitchildrenset() and files(). The two former now also accept '' as
input. I've updated the callers of these methods. I've also added a
deprecation warning for passing '.' (for external callers). The only
caller I could find that was affected by files() returning '' instead
of '.' was in dirstate.walk(). I've updated that.

The next few patches show some workarounds we can remove by using ''
instead of '.'.

Differential Revision: https://phab.mercurial-scm.org/D6401

42340:7ada598941d2

            return lookupmflinknode

        while tmfnodes:
            tree, nodes = tmfnodes.popitem()

            should_visit = self._matcher.visitdir(tree[:-1] or '.')
            if tree and not should_visit:
                continue

            store = mfl.getstorage(tree)

                topic=_('manifests'),
                clrevtolocalrev=clrevtolocalrev,
                fullclnodes=self._fullclnodes,
                precomputedellipsis=self._precomputedellipsis)

            if not self._oldmatcher.visitdir(store.tree[:-1] or '.'):
                yield tree, deltas
            else:
                # 'deltas' is a generator and we need to consume it even if
                # we are not going to send it because a side-effect is that
                # it updates tmdnodes (via lookupfn)

42341:27d6956d386b

            return lookupmflinknode

        while tmfnodes:
            tree, nodes = tmfnodes.popitem()

            should_visit = self._matcher.visitdir(tree[:-1])
            if tree and not should_visit:
                continue

            store = mfl.getstorage(tree)

                topic=_('manifests'),
                clrevtolocalrev=clrevtolocalrev,
                fullclnodes=self._fullclnodes,
                precomputedellipsis=self._precomputedellipsis)

            if not self._oldmatcher.visitdir(store.tree[:-1]):
                yield tree, deltas
            else:
                # 'deltas' is a generator and we need to consume it even if
                # we are not going to send it because a side-effect is that
                # it updates tmdnodes (via lookupfn)