comparison mercurial/exchange.py @ 42209:280f7a095df8 stable

narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

Before this patch, when ACL is involved, narrowspecs are send as bundle2
parameter for narrow:spec bundle2 part. The limitation of bundle2 parts are they
cannot send data larger than 255 bytes. Includes and excludes in narrow are not
limited by size and they can grow over 255 bytes.

This patch introduces a new mandatory bundle2 part and send narrowspecs as data
of that. The new bundle2 part is introduced to keep things cleaner and easy to
distinguish related to backward compatibility.
The part is mandatory because without server's narrowspec, the local ACL narrow
repo won't work.

This patch makes clients compatible with servers which have older versions.
However I left a comment that we should drop the other bundle2 part soon as
that's broken and people should not rely on that.

I named the new bundle2 part 'Narrow:responsespec' because:

1) Capital 'N' to make it mandatory
2) 'Narrow:spec' cannot be used because bundle2 enforces that there should not
be two different parts which resolve to same name when lowercased.
3) reponsespec clears that they are specs which are send as reponse by the
server

While I was here, I renamed `narrowhgacl` section to `narrowacl` as suggested by
idlsoft@ and martinvonz@.

Differential Revision: https://phab.mercurial-scm.org/D6310

42204:723ed4402896

)

urlerr = util.urlerr
urlreq = util.urlreq

_NARROWACL_SECTION = 'narrowhgacl'

# Maps bundle version human names to changegroup versions.
_bundlespeccgversions = {'v1': '01',
                         'v2': '02',
                         'packed1': 's1',

    if 'treemanifest' in repo.requirements:
        part.addparam('treemanifest', '1')

    if (kwargs.get(r'narrow', False) and kwargs.get(r'narrow_acl', False)
        and (include or exclude)):
        narrowspecpart = bundler.newpart('narrow:spec')
        if include:
            narrowspecpart.addparam(
                'include', '\n'.join(include), mandatory=True)
        if exclude:
            narrowspecpart.addparam(
                'exclude', '\n'.join(exclude), mandatory=True)

@getbundle2partsgenerator('bookmarks')
def _getbundlebookmarkpart(bundler, repo, source, bundlecaps=None,
                              b2caps=None, **kwargs):
    """add a bookmark part to the requested bundle"""

42209:280f7a095df8

)

urlerr = util.urlerr
urlreq = util.urlreq

_NARROWACL_SECTION = 'narrowacl'

# Maps bundle version human names to changegroup versions.
_bundlespeccgversions = {'v1': '01',
                         'v2': '02',
                         'packed1': 's1',

    if 'treemanifest' in repo.requirements:
        part.addparam('treemanifest', '1')

    if (kwargs.get(r'narrow', False) and kwargs.get(r'narrow_acl', False)
        and (include or exclude)):
        # this is mandatory because otherwise ACL clients won't work
        narrowspecpart = bundler.newpart('Narrow:responsespec')
        narrowspecpart.data = '%s\0%s' % ('\n'.join(include),
                                           '\n'.join(exclude))

@getbundle2partsgenerator('bookmarks')
def _getbundlebookmarkpart(bundler, repo, source, bundlecaps=None,
                              b2caps=None, **kwargs):
    """add a bookmark part to the requested bundle"""