comparison mercurial/repository.py @ 39873:2ac4f3e97813

filelog: stop proxying flags() (API) Per-revision storage flags are kinda a revlog-centric API. (Except for the fact that changegroup uses the same integer flags as revlog does and there's minimal verification that the server's flags map to the client's storage flags - but that's another problem.) The last user of flags() was in verify.py and that code was just moved into revlog.py and is accessed behind the verifyintegrity() file storage API. Since there are no more consumers, let's drop the proxy and remove the method from the file storage interface. This commit only drops the dedicated API for reading a single revision's storage flags: we still support reading and writing flags through the bulk data retrieval and add revision APIs. And since changegroups encode revlog integer flags over the wire, we'll always need to support flags at some level. The removal of individual storage flags may be too premature. But since flags() is now unused, I'd like to see how far we can get without that dedicated API - especially since it uses revision numbers instead of nodes. Differential Revision: https://phab.mercurial-scm.org/D4746
author Gregory Szorc <gregory.szorc@gmail.com>
date Mon, 24 Sep 2018 11:16:33 -0700
parents 733db72f0f54
children d909c44d29e1
comparison
equal deleted inserted replaced
39872:733db72f0f54 39873:2ac4f3e97813
500 """ 500 """
501 501
502 def linkrev(rev): 502 def linkrev(rev):
503 """Obtain the changeset revision number a revision is linked to.""" 503 """Obtain the changeset revision number a revision is linked to."""
504 504
505 def flags(rev):
506 """Obtain flags used to affect storage of a revision."""
507
508 def iscensored(rev): 505 def iscensored(rev):
509 """Return whether a revision's content has been censored.""" 506 """Return whether a revision's content has been censored."""
510 507
511 def commonancestorsheads(node1, node2): 508 def commonancestorsheads(node1, node2):
512 """Obtain an iterable of nodes containing heads of common ancestors. 509 """Obtain an iterable of nodes containing heads of common ancestors.