comparison mercurial/profiling.py @ 32805:2b0fc56840d0

profile: use explicit logic to control file closing

We make the decision to close 'fp' more explicit instead of relying on the
implication of other variable. This makes the overall logic more robust.

32804:c0b2c8f25ad9

    """
    def __init__(self, ui, enabled=True):
        self._ui = ui
        self._output = None
        self._fp = None
        self._profiler = None
        self._enabled = enabled
        self._entered = False
        self._started = False

            self._fp = util.stringio()
        elif self._output:
            path = self._ui.expandpath(self._output)
            self._fp = open(path, 'wb')
        else:
            self._fp = self._ui.ferr

        if proffn is not None:
            pass
        elif profiler == 'ls':

                val = val.replace('%', '%%')
                self._ui.log('profile', val)
            self._closefp()

    def _closefp(self):
        self._fp.close()

32805:2b0fc56840d0

    """
    def __init__(self, ui, enabled=True):
        self._ui = ui
        self._output = None
        self._fp = None
        self._fpdoclose = True
        self._profiler = None
        self._enabled = enabled
        self._entered = False
        self._started = False

            self._fp = util.stringio()
        elif self._output:
            path = self._ui.expandpath(self._output)
            self._fp = open(path, 'wb')
        else:
            self._fpdoclose = False
            self._fp = self._ui.ferr

        if proffn is not None:
            pass
        elif profiler == 'ls':

                val = val.replace('%', '%%')
                self._ui.log('profile', val)
            self._closefp()

    def _closefp(self):
        if self._fpdoclose and self._fp is not None:
            self._fp.close()