comparison tests/test-branches.t @ 51492:2e8a88e5809f

branchcache: stop writing more branchcache file on disk than needed

Before this change, we were unconditionally writing a branchmap file for the
filter level passed to `update_disk`. This is actually counter productive if no
update were needed for this filter level. In many case, the branch cache for a
filter level is identical to its parent "subset" and it is better to simply
keep the subset update and reuse it every time instead of having to do identical
work for similar subset.

So we change the `update_disk` method to only write a file when that filter
level differ from its parent. This removes many cases where identical files were
written, requiring multiple boring update in the test suite.

The only notable changes is the change to `test-strip-branch-cache.t`, this
case was checking a scenario that no longer reproduce the bug as writing less
branchmap file result in less stalled cache on disk.

Strictly speaking, we could create a more convoluted scenario that create a
similar issue. However the next changeset would also cover that scenario so we
directly updated that test case to a "no longer buggy" state.

51491:dd5b5f99940d

  adding file changes
  added 2 changesets with 0 changes to 0 files
  new changesets 2ab8003a1750:99ba08759bc7
  updating to branch A
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ cat branchmap-update-01/.hg/cache/branch2-served
  99ba08759bc7f6fdbe5304e83d0387f35c082479 1
  99ba08759bc7f6fdbe5304e83d0387f35c082479 o A
  $ hg -R branchmap-update-01 unbundle bundle.hg
  adding changesets
  adding manifests

  added 2 changesets with 0 changes to 0 files
  new changesets 2ab8003a1750:99ba08759bc7
  updating to branch A
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

  $ cat branchmap-update-02/.hg/cache/branch2-served
  99ba08759bc7f6fdbe5304e83d0387f35c082479 1
  99ba08759bc7f6fdbe5304e83d0387f35c082479 o A
  $ hg -R branchmap-update-02 unbundle bundle.hg --config "hooks.pretxnclose=python:$TESTTMP/simplehook.py:hook"
  adding changesets
  adding manifests
  adding file changes
  transaction abort!
  rollback completed
  abort: pretxnclose hook failed
  [40]
  $ cat branchmap-update-02/.hg/cache/branch2-served
  99ba08759bc7f6fdbe5304e83d0387f35c082479 1
  99ba08759bc7f6fdbe5304e83d0387f35c082479 o A

51492:2e8a88e5809f

  adding file changes
  added 2 changesets with 0 changes to 0 files
  new changesets 2ab8003a1750:99ba08759bc7
  updating to branch A
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ cat branchmap-update-01/.hg/cache/branch2-base
  99ba08759bc7f6fdbe5304e83d0387f35c082479 1
  99ba08759bc7f6fdbe5304e83d0387f35c082479 o A
  $ hg -R branchmap-update-01 unbundle bundle.hg
  adding changesets
  adding manifests

  added 2 changesets with 0 changes to 0 files
  new changesets 2ab8003a1750:99ba08759bc7
  updating to branch A
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

  $ cat branchmap-update-02/.hg/cache/branch2-base
  99ba08759bc7f6fdbe5304e83d0387f35c082479 1
  99ba08759bc7f6fdbe5304e83d0387f35c082479 o A
  $ hg -R branchmap-update-02 unbundle bundle.hg --config "hooks.pretxnclose=python:$TESTTMP/simplehook.py:hook"
  adding changesets
  adding manifests
  adding file changes
  transaction abort!
  rollback completed
  abort: pretxnclose hook failed
  [40]
  $ cat branchmap-update-02/.hg/cache/branch2-base
  99ba08759bc7f6fdbe5304e83d0387f35c082479 1
  99ba08759bc7f6fdbe5304e83d0387f35c082479 o A