comparison tests/test-treediscovery.t @ 22503:300e07582e9b stable

revset: add an optimised baseset.__contains__ (issue4371) The baseset class is based on a python list. This means that base.__contains__ was absolutely as crappy as list.__contains__. We now rely on __contains__ from the underlying set. This will avoid having to explicitly convert the baseset to a set (using baseset.set()) whenever one want fast membership test. Apparently there is already code that forgot to do such conversions since we observe a massive speedup in some test. revset #25: roots((0::) - (0::tip)) 0) wall 2.079454 comb 2.080000 user 2.080000 sys 0.000000 (best of 5) 1) wall 0.132970 comb 0.130000 user 0.130000 sys 0.000000 (best of 65) No regression is observed in benchmarks. This change improve the issue4371 back to acceptable situation (but are still slower than manual substraction)
author Pierre-Yves David <pierre-yves.david@fb.com>
date Tue, 16 Sep 2014 23:59:29 -0700
parents 510cafe72004
children 8dda6f6ff564
comparison
equal deleted inserted replaced
22493:abf4e98b8ff2 22503:300e07582e9b