Mercurial: tests/test-hook.t comparison

comparison tests/test-hook.t @ 30234:34a5f6c66bc5 stable

tests: invoke printenv.py via sh -c for test portability On Windows platform, invoking printenv.py directly via hook is problematic, because: - unless binding between *.py suffix and python runtime, application selector dialog is displayed, and running test is blocked at each printenv.py invocations - it isn't safe to assume binding between *.py suffix and python runtime, because application binding is easily broken For example, installing IDE (VisualStudio with Python Tools, or so) often requires binding between source files and IDE itself. This patch invokes printenv.py via sh -c for test portability. This is a kind of follow up for d19787db6fe0, which eliminated explicit "python" for printenv.py. There are already other 'sh -c "printenv.py"' in *.t files, and this fix should be reasonable. This changes were confirmed in cases below: - without any application binding for *.py suffix - with binding between *.py suffix and VisualStudio This patch also replaces "echo + redirection" style with "heredoc" style, because: - hook command line is parsed by cmd.exe as shell at first, and - single quotation can't quote arguments on cmd.exe, therefore, - "printenv.py foobar" should be quoted by double quotation, but - nested quoting (or tricky escaping) isn't readable

author	FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
date	Sat, 29 Oct 2016 02:44:45 +0900
parents	769aee32fae0
children	59e69ed81776

comparison

equal deleted inserted replaced

-:3afde791dce1
+:34a5f6c66bc5
 > commit = sh -c "HG_LOCAL= HG_TAG= printenv.py commit"
 > commit.b = sh -c "HG_LOCAL= HG_TAG= printenv.py commit.b"
 > precommit = sh -c  "HG_LOCAL= HG_NODE= HG_TAG= printenv.py precommit"
 > pretxncommit = sh -c "HG_LOCAL= HG_TAG= printenv.py pretxncommit"
 > pretxncommit.tip = hg -q tip
-> pre-identify = printenv.py pre-identify 1
+> pre-identify = sh -c "printenv.py pre-identify 1"
-> pre-cat = printenv.py pre-cat
+> pre-cat = sh -c "printenv.py pre-cat"
-> post-cat = printenv.py post-cat
+> post-cat = sh -c "printenv.py post-cat"
 > pretxnopen = sh -c "HG_LOCAL= HG_TAG= printenv.py pretxnopen"
 > pretxnclose = sh -c "HG_LOCAL= HG_TAG= printenv.py pretxnclose"
 > txnclose = sh -c "HG_LOCAL= HG_TAG= printenv.py txnclose"
 > txnabort.0 = python:$TESTTMP/txnabort.checkargs.py:showargs
 > txnabort.1 = sh -c "HG_LOCAL= HG_TAG= printenv.py txnabort"
 changegroup hooks can see env vars
 $ cat > .hg/hgrc <<EOF
 > [hooks]
-> prechangegroup = printenv.py prechangegroup
+> prechangegroup = sh -c "printenv.py prechangegroup"
-> changegroup = printenv.py changegroup
+> changegroup = sh -c "printenv.py changegroup"
-> incoming = printenv.py incoming
+> incoming = sh -c "printenv.py incoming"
 > EOF
 pretxncommit and commit hooks can see both parents of merge
 $ cd ../a
 tag hooks can see env vars
 $ cd ../a
 $ cat >> .hg/hgrc <<EOF
-> pretag = printenv.py pretag
+> pretag = sh -c "printenv.py pretag"
 > tag = sh -c "HG_PARENT1= HG_PARENT2= printenv.py tag"
 > EOF
 $ hg tag -d '3 0' a
 pretag hook: HG_LOCAL=0 HG_NODE=07f3376c1e655977439df2a814e3cc14b27abac2 HG_TAG=a
 precommit hook: HG_PARENT1=07f3376c1e655977439df2a814e3cc14b27abac2
 pretag hook: HG_LOCAL=1 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_TAG=la
 tag hook: HG_LOCAL=1 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_TAG=la
 pretag hook can forbid tagging
-$ echo "pretag.forbid = printenv.py pretag.forbid 1" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> pretag.forbid = sh -c "printenv.py pretag.forbid 1"
+> EOF
 $ hg tag -d '4 0' fa
 pretag hook: HG_LOCAL=0 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_TAG=fa
 pretag.forbid hook: HG_LOCAL=0 HG_NODE=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10 HG_TAG=fa
 abort: pretag.forbid hook exited with status 1
 [255]
 [255]
 pretxncommit hook can see changeset, can roll back txn, changeset no
 more there after
-$ echo "pretxncommit.forbid0 = hg tip -q" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
-$ echo "pretxncommit.forbid1 = printenv.py pretxncommit.forbid 1" >> .hg/hgrc
+> pretxncommit.forbid0 = sh -c "hg tip -q"
+> pretxncommit.forbid1 = sh -c "printenv.py pretxncommit.forbid 1"
+> EOF
 $ echo z > z
 $ hg add z
 $ hg -q tip
 4:539e4b31b6dc
 $ hg commit -m 'fail' -d '4 0'
 undo.phaseroots
 precommit hook can prevent commit
-$ echo "precommit.forbid = printenv.py precommit.forbid 1" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> precommit.forbid = sh -c "printenv.py precommit.forbid 1"
+> EOF
 $ hg commit -m 'fail' -d '4 0'
 precommit hook: HG_PARENT1=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
 precommit.forbid hook: HG_PARENT1=539e4b31b6dc99b3cfbaa6b53cbc1c1f9a1e3a10
 abort: precommit.forbid hook exited with status 1
 [255]
 $ hg -q tip
 4:539e4b31b6dc
 preupdate hook can prevent update
-$ echo "preupdate = printenv.py preupdate" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> preupdate = sh -c "printenv.py preupdate"
+> EOF
 $ hg update 1
 preupdate hook: HG_PARENT1=ab228980c14d
 0 files updated, 0 files merged, 2 files removed, 0 files unresolved
 update hook
-$ echo "update = printenv.py update" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> update = sh -c "printenv.py update"
+> EOF
 $ hg update
 preupdate hook: HG_PARENT1=539e4b31b6dc
 update hook: HG_ERROR=0 HG_PARENT1=539e4b31b6dc
 2 files updated, 0 files merged, 0 files removed, 0 files unresolved
 pushkey hook
-$ echo "pushkey = printenv.py pushkey" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> pushkey = sh -c "printenv.py pushkey"
+> EOF
 $ cd ../b
 $ hg bookmark -r null foo
 $ hg push -B foo ../a
 pushing to ../a
 searching for changes
 [1]
 $ cd ../a
 listkeys hook
-$ echo "listkeys = printenv.py listkeys" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> listkeys = sh -c "printenv.py listkeys"
+> EOF
 $ hg bookmark -r null bar
 pretxnopen hook: HG_TXNID=TXN:* HG_TXNNAME=bookmark (glob)
 pretxnclose hook: HG_BOOKMARK_MOVED=1 HG_PENDING=$TESTTMP/a HG_TXNID=TXN:* HG_TXNNAME=bookmark (glob)
 txnclose hook: HG_BOOKMARK_MOVED=1 HG_TXNID=TXN:* HG_TXNNAME=bookmark (glob)
 $ cd ../b
 adding remote bookmark bar
 $ cd ../a
 test that prepushkey can prevent incoming keys
-$ echo "prepushkey = printenv.py prepushkey.forbid 1" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> prepushkey = sh -c "printenv.py prepushkey.forbid 1"
+> EOF
 $ cd ../b
 $ hg bookmark -r null baz
 $ hg push -B baz ../a
 pushing to ../a
 searching for changes
 [255]
 $ cd ../a
 test that prelistkeys can prevent listing keys
-$ echo "prelistkeys = printenv.py prelistkeys.forbid 1" >> .hg/hgrc
+$ cat >> .hg/hgrc <<EOF
+> prelistkeys = sh -c "printenv.py prelistkeys.forbid 1"
+> EOF
 $ hg bookmark -r null quux
 pretxnopen hook: HG_TXNID=TXN:* HG_TXNNAME=bookmark (glob)
 pretxnclose hook: HG_BOOKMARK_MOVED=1 HG_PENDING=$TESTTMP/a HG_TXNID=TXN:* HG_TXNNAME=bookmark (glob)
 txnclose hook: HG_BOOKMARK_MOVED=1 HG_TXNID=TXN:* HG_TXNNAME=bookmark (glob)
 $ cd ../b
 $ cd ../b
 $ hg -q tip
 3:07f3376c1e65
 $ cat > .hg/hgrc <<EOF
 > [hooks]
-> prechangegroup.forbid = printenv.py prechangegroup.forbid 1
+> prechangegroup.forbid = sh -c "printenv.py prechangegroup.forbid 1"
 > EOF
 $ hg pull ../a
 pulling from ../a
 searching for changes
 prechangegroup.forbid hook: HG_SOURCE=pull HG_TXNID=TXN:* HG_URL=file:$TESTTMP/a (glob)
 incoming changes no longer there after
 $ cat > .hg/hgrc <<EOF
 > [hooks]
 > pretxnchangegroup.forbid0 = hg tip -q
-> pretxnchangegroup.forbid1 = printenv.py pretxnchangegroup.forbid 1
+> pretxnchangegroup.forbid1 = sh -c "printenv.py pretxnchangegroup.forbid 1"
 > EOF
 $ hg pull ../a
 pulling from ../a
 searching for changes
 adding changesets
 outgoing hooks can see env vars
 $ rm .hg/hgrc
 $ cat > ../a/.hg/hgrc <<EOF
 > [hooks]
-> preoutgoing = printenv.py preoutgoing
+> preoutgoing = sh -c "printenv.py preoutgoing"
-> outgoing = printenv.py outgoing
+> outgoing = sh -c "printenv.py outgoing"
 > EOF
 $ hg pull ../a
 pulling from ../a
 searching for changes
 preoutgoing hook: HG_SOURCE=pull
 $ hg rollback
 repository tip rolled back to revision 3 (undo pull)
 preoutgoing hook can prevent outgoing changes
-$ echo "preoutgoing.forbid = printenv.py preoutgoing.forbid 1" >> ../a/.hg/hgrc
+$ cat >> ../a/.hg/hgrc <<EOF
+> preoutgoing.forbid = sh -c "printenv.py preoutgoing.forbid 1"
+> EOF
 $ hg pull ../a
 pulling from ../a
 searching for changes
 preoutgoing hook: HG_SOURCE=pull
 preoutgoing.forbid hook: HG_SOURCE=pull
 outgoing hooks work for local clones
 $ cd ..
 $ cat > a/.hg/hgrc <<EOF
 > [hooks]
-> preoutgoing = printenv.py preoutgoing
+> preoutgoing = sh -c "printenv.py preoutgoing"
-> outgoing = printenv.py outgoing
+> outgoing = sh -c "printenv.py outgoing"
 > EOF
 $ hg clone a c
 preoutgoing hook: HG_SOURCE=clone
 outgoing hook: HG_NODE=0000000000000000000000000000000000000000 HG_SOURCE=clone
 updating to branch default
 3 files updated, 0 files merged, 0 files removed, 0 files unresolved
 $ rm -rf c
 preoutgoing hook can prevent outgoing changes for local clones
-$ echo "preoutgoing.forbid = printenv.py preoutgoing.forbid 1" >> a/.hg/hgrc
+$ cat >> a/.hg/hgrc <<EOF
+> preoutgoing.forbid = sh -c "printenv.py preoutgoing.forbid 1"
+> EOF
 $ hg clone a zzz
 preoutgoing hook: HG_SOURCE=clone
 preoutgoing.forbid hook: HG_SOURCE=clone
 abort: preoutgoing.forbid hook exited with status 1
 [255]
 This also creates the `to` repo for the next test block.
 $ cd ..
 $ cat << EOF >> hgrc-with-post-init-hook
 > [hooks]
-> post-init = printenv.py post-init
+> post-init = sh -c "printenv.py post-init"
 > EOF
 $ HGRCPATH=hgrc-with-post-init-hook hg init to
 post-init hook: HG_ARGS=init to HG_OPTS={'insecure': None, 'remotecmd': '', 'ssh': ''} HG_PATS=['to'] HG_RESULT=0
 new commits must be visible in pretxnchangegroup (issue3428)

Mercurial > hg

comparison tests/test-hook.t @ 30234:34a5f6c66bc5 stable