comparison mercurial/httpclient/__init__.py @ 19038:36733ab7fa05

http2: sane readline

It turns out that it pays off to read more than a byte at a time with
a select in between :)

19037:1fde25ad9396

        """Read a single line from the response body.

        This may block until either a line ending is found or the
        response is complete.
        """
        # TODO: move this into the reader interface where it can be
        # smarter (and probably avoid copies)
        bytes = []
        while not bytes:
            try:
                bytes = [self._reader.read(1)]
            except _readers.ReadNotReady:
                self._select()
        while bytes[-1] != '\n' and not self.complete():
            self._select()
            bytes.append(self._reader.read(1))
        if bytes[-1] != '\n':
            next = self._reader.read(1)
            while next and next != '\n':
                bytes.append(next)
                next = self._reader.read(1)
            bytes.append(next)
        return ''.join(bytes)

    def read(self, length=None):
        # if length is None, unbounded read
        while (not self.complete()  # never select on a finished read
               and (not length  # unbounded, so we wait for complete()

19038:36733ab7fa05

        """Read a single line from the response body.

        This may block until either a line ending is found or the
        response is complete.
        """
        blocks = []
        while True:
            self._reader.readto('\n', blocks)

            if blocks and blocks[-1][-1] == '\n' or self.complete():
                break

            self._select()

        return ''.join(blocks)

    def read(self, length=None):
        # if length is None, unbounded read
        while (not self.complete()  # never select on a finished read
               and (not length  # unbounded, so we wait for complete()