comparison mercurial/httppeer.py @ 40034:393e44324037

httppeer: report http statistics

Now that keepalive.py records HTTP request count and the
number of bytes sent and received as part of performing those
requests, we can easily print a report on the activity when
closing a peer instance!

Exact byte counts are globbed in tests because they are influenced
by non-deterministic things, such as hostnames and port numbers.
Plus, the exact byte count isn't too important anyway.

I feel obliged to note that printing the byte count could have
security implications. e.g. if sending a password via HTTP basic
auth, the length of that password will influence the byte count
and the reporting of the byte count could be a side-channel leak
of the password length. I /think/ this is beyond our threshold
for concern. But if we think it poses a problem, we can teach the
byte count logging code to e.g. ignore sensitive HTTP request
headers. We could also consider not reporting the byte count of
request headers altogether. But since the wire protocol uses HTTP
headers for sending command arguments, it is kind of important to
report their size.

Differential Revision: https://phab.mercurial-scm.org/D4858

40033:5e5b06087ec5

    def canpush(self):
        return True

    def close(self):
        pass

    # End of ipeerconnection interface.

    # Begin of ipeercommands interface.

    def canpush(self):
        # TODO change once implemented.
        return False

    def close(self):
        pass

    # End of ipeerconnection.

    # Start of ipeercapabilities.

40034:393e44324037

    def canpush(self):
        return True

    def close(self):
        self.ui.note(_('(sent %d HTTP requests and %d bytes; '
                       'received %d bytes in responses)\n') %
                     (self._urlopener.requestscount,
                      self._urlopener.sentbytescount,
                      self._urlopener.receivedbytescount))

    # End of ipeerconnection interface.

    # Begin of ipeercommands interface.

    def canpush(self):
        # TODO change once implemented.
        return False

    def close(self):
        self.ui.note(_('(sent %d HTTP requests and %d bytes; '
                       'received %d bytes in responses)\n') %
                     (self._opener.requestscount,
                      self._opener.sentbytescount,
                      self._opener.receivedbytescount))

    # End of ipeerconnection.

    # Start of ipeercapabilities.