comparison mercurial/httppeer.py @ 37320:39f7d4ee8bcd

repository: port peer interfaces to zope.interface

zope.interface is superior. Let's switch to it.

Unlike abc, which defines interfaces through a base class,
zope.interface uses different types for interfaces and for
implementations. So, we had to invent some new types to hold the
interfaces in order to separate the interface from its default
implementation.

The names here could probably be better. I've been wanting to
overhaul the peer interface for a while. And wire protocol version
2 will force that work. So anticipate a refactoring of these
interfaces in later commits.

With this commit, we no longer test abc interfaces in
test-check-interfaces.py, so code for that has been removed.

Differential Revision: https://phab.mercurial-scm.org/D3068

# no-check-commit because of stream_out()

37319:36d17f37db91

        if self._ui.configbool('devel', 'debug.peer-request'):
            dbg(line % '  finished in %.4f seconds (%s)'
                % (util.timer() - start, ret.code))
        return ret

    # Begin of _basepeer interface.

    @util.propertycache
    def ui(self):
        return self._ui

        return True

    def close(self):
        pass

    # End of _basepeer interface.

    # Begin of _basewirepeer interface.

    def capabilities(self):
        # self._fetchcaps() should have been called as part of peer
        # handshake. So self._caps should always be set.
        assert self._caps is not None
        return self._caps

    # End of _basewirepeer interface.

    # look up capabilities only when needed

    def _fetchcaps(self):
        self._caps = set(self._call('capabilities').split())

37320:39f7d4ee8bcd

        if self._ui.configbool('devel', 'debug.peer-request'):
            dbg(line % '  finished in %.4f seconds (%s)'
                % (util.timer() - start, ret.code))
        return ret

    # Begin of ipeerconnection interface.

    @util.propertycache
    def ui(self):
        return self._ui

        return True

    def close(self):
        pass

    # End of ipeerconnection interface.

    # Begin of ipeercommands interface.

    def capabilities(self):
        # self._fetchcaps() should have been called as part of peer
        # handshake. So self._caps should always be set.
        assert self._caps is not None
        return self._caps

    # End of ipeercommands interface.

    # look up capabilities only when needed

    def _fetchcaps(self):
        self._caps = set(self._call('capabilities').split())