comparison mercurial/revlog.py @ 37971:3ac950cd5978

shortest: move revnum-disambiguation out of revlog

I want to be able to change how we disambiguate and I think having
revlog.shortest() worry only about finding a prefix that's unambiguous
among nodeids makes more sense.

This slows down `hg log -T '{shortest(node,1)}\n'` from 4.0s to 4.1s.

Differential Revision: https://phab.mercurial-scm.org/D3502

37970:76e933e0ccc9

        raise LookupError(id, self.indexfile, _('no match found'))

    def shortest(self, node, minlength=1):
        """Find the shortest unambiguous prefix that matches node."""
        def isrev(prefix):
            try:
                i = int(prefix)
                # if we are a pure int, then starting with zero will not be
                # confused as a rev; or, obviously, if the int is larger
                # than the value of the tip rev
                if prefix[0] == '0' or i > len(self):
                    return False
                return True
            except ValueError:
                return False

        def isvalid(prefix):
            try:
                node = self._partialmatch(prefix)
            except error.RevlogError:
                return False

            return all(c == 'f' for c in prefix)

        hexnode = hex(node)

        def disambiguate(hexnode, minlength):
            for length in range(minlength, 41):
                prefix = hexnode[:length]
                if not isrev(prefix) and not maybewdir(prefix):
                    return prefix

        if not getattr(self, 'filteredrevs', None):
            try:
                length = max(self.index.shortest(node), minlength)

37971:3ac950cd5978

        raise LookupError(id, self.indexfile, _('no match found'))

    def shortest(self, node, minlength=1):
        """Find the shortest unambiguous prefix that matches node."""
        def isvalid(prefix):
            try:
                node = self._partialmatch(prefix)
            except error.RevlogError:
                return False

            return all(c == 'f' for c in prefix)

        hexnode = hex(node)

        def disambiguate(hexnode, minlength):
            """Disambiguate against wdirid."""
            for length in range(minlength, 41):
                prefix = hexnode[:length]
                if not maybewdir(prefix):
                    return prefix

        if not getattr(self, 'filteredrevs', None):
            try:
                length = max(self.index.shortest(node), minlength)