comparison contrib/check-code.py @ 16483:3c4910364797 stable

tests: ^ must be quoted when used on solaris sh The check was broken when it was introduced in 6e4cf8319f54.
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 23 Apr 2012 01:39:26 +0200
parents 9b26d541e972
children f48b075ff088
comparison
equal deleted inserted replaced
16482:a5d359b3927a 16483:3c4910364797
63 "use egrep for extended grep syntax"), 63 "use egrep for extended grep syntax"),
64 (r'/bin/', "don't use explicit paths for tools"), 64 (r'/bin/', "don't use explicit paths for tools"),
65 (r'\$PWD', "don't use $PWD, use `pwd`"), 65 (r'\$PWD', "don't use $PWD, use `pwd`"),
66 (r'[^\n]\Z', "no trailing newline"), 66 (r'[^\n]\Z', "no trailing newline"),
67 (r'export.*=', "don't export and assign at once"), 67 (r'export.*=', "don't export and assign at once"),
68 (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\\^', "^ must be quoted"), 68 (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
69 (r'^source\b', "don't use 'source', use '.'"), 69 (r'^source\b', "don't use 'source', use '.'"),
70 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), 70 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
71 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), 71 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
72 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), 72 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
73 (r'^stop\(\)', "don't use 'stop' as a shell function name"), 73 (r'^stop\(\)', "don't use 'stop' as a shell function name"),