comparison hgext/largefiles/overrides.py @ 30142:3dcaf1c4e90d

largefiles: use context for file closing

Make the code slightly smaller and safer (and more deeply indented).

30141:c01acee367ec

        if not repo:
            return result

        # If largefiles is required for this repo, permanently enable it locally
        if 'largefiles' in repo.requirements:
            fp = repo.vfs('hgrc', 'a', text=True)
            try:
                fp.write('\n[extensions]\nlargefiles=\n')
            finally:
                fp.close()

        # Caching is implicitly limited to 'rev' option, since the dest repo was
        # truncated at that point.  The user may expect a download count with
        # this option, so attempt whether or not this is a largefile repo.
        if opts.get('all_largefiles'):

            return False
        return origvisitdirfn(lf)
    m.visitdir = lfvisitdirfn

    for f in ctx.walk(m):
        fp = cmdutil.makefileobj(repo, opts.get('output'), ctx.node(),
                                 pathname=f)
        lf = lfutil.splitstandin(f)
        if lf is None or origmatchfn(f):
            # duplicating unreachable code from commands.cat
            data = ctx[f].data()
            if opts.get('decode'):
                data = repo.wwritedata(f, data)
            fp.write(data)
        else:
            hash = lfutil.readstandin(repo, lf, ctx.rev())
            if not lfutil.inusercache(repo.ui, hash):
                store = storefactory.openstore(repo)
                success, missing = store.get([(lf, hash)])
                if len(success) != 1:
                    raise error.Abort(
                        _('largefile %s is not in cache and could not be '
                          'downloaded')  % lf)
            path = lfutil.usercachepath(repo.ui, hash)
            fpin = open(path, "rb")
            for chunk in util.filechunkiter(fpin, 128 * 1024):
                fp.write(chunk)
            fpin.close()
        fp.close()
        err = 0
    return err

def mergeupdate(orig, repo, node, branchmerge, force,
                *args, **kwargs):

30142:3dcaf1c4e90d

        if not repo:
            return result

        # If largefiles is required for this repo, permanently enable it locally
        if 'largefiles' in repo.requirements:
            with repo.vfs('hgrc', 'a', text=True) as fp:
                fp.write('\n[extensions]\nlargefiles=\n')

        # Caching is implicitly limited to 'rev' option, since the dest repo was
        # truncated at that point.  The user may expect a download count with
        # this option, so attempt whether or not this is a largefile repo.
        if opts.get('all_largefiles'):

            return False
        return origvisitdirfn(lf)
    m.visitdir = lfvisitdirfn

    for f in ctx.walk(m):
        with cmdutil.makefileobj(repo, opts.get('output'), ctx.node(),
                                 pathname=f) as fp:
            lf = lfutil.splitstandin(f)
            if lf is None or origmatchfn(f):
                # duplicating unreachable code from commands.cat
                data = ctx[f].data()
                if opts.get('decode'):
                    data = repo.wwritedata(f, data)
                fp.write(data)
            else:
                hash = lfutil.readstandin(repo, lf, ctx.rev())
                if not lfutil.inusercache(repo.ui, hash):
                    store = storefactory.openstore(repo)
                    success, missing = store.get([(lf, hash)])
                    if len(success) != 1:
                        raise error.Abort(
                            _('largefile %s is not in cache and could not be '
                              'downloaded')  % lf)
                path = lfutil.usercachepath(repo.ui, hash)
                with open(path, "rb") as fpin:
                    for chunk in util.filechunkiter(fpin, 128 * 1024):
                        fp.write(chunk)
        err = 0
    return err

def mergeupdate(orig, repo, node, branchmerge, force,
                *args, **kwargs):