Mercurial > hg
comparison tests/test-ssh-bundle1.t @ 40176:41263df08109
wireprotov2: change how revisions are specified to changesetdata
Right now, we have a handful of arguments for specifying the revisions
whose data should be returned. Defining how all these arguments
interact when various combinations are present is difficult.
This commit establishes a new, generic mechanism for specifying
revisions. Instead of a hodgepodge of arguments defining things, we
have a list of dicts that specify revision selectors. The final set
of revisions is a union of all these selectors.
We implement support for specifying revisions based on:
* An explicit list of changeset revisions
* An explicit list of changeset revisions plus ancestry depth
* A DAG range between changeset roots and heads
If you squint hard enough, this problem has already been solved by
revsets. But I'm reluctant to expose revsets to the wire protocol
because that would require servers to implement a revset parser.
Plus there are security and performance implications: the set
of revision selectors needs to be narrowly and specifically tailored
for what is appropriate to be executing on a server. Perhaps there
would be a way for us to express the "parse tree" of a revset
query, for example. I'm not sure. We can explore this space another
time. For now, the new mechanism should bring sufficient flexibility
while remaining relatively simple.
The selector "types" are prefixed with "changeset" because I plan
to add manifest and file-flavored selectors as well. This will enable
us to e.g. select file revisions based on a range of changeset
revisions.
Differential Revision: https://phab.mercurial-scm.org/D4979
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Mon, 08 Oct 2018 18:17:12 -0700 |
parents | d059cb669632 |
children | 52b773f5e9a4 |
comparison
equal
deleted
inserted
replaced
40175:6c42409691ec | 40176:41263df08109 |
---|---|
477 debug output | 477 debug output |
478 | 478 |
479 $ hg pull --debug ssh://user@dummy/remote | 479 $ hg pull --debug ssh://user@dummy/remote |
480 pulling from ssh://user@dummy/remote | 480 pulling from ssh://user@dummy/remote |
481 running .* ".*/dummyssh" ['"]user@dummy['"] ('|")hg -R remote serve --stdio('|") (re) | 481 running .* ".*/dummyssh" ['"]user@dummy['"] ('|")hg -R remote serve --stdio('|") (re) |
482 sending upgrade request: * proto=exp-ssh-v2-0002 (glob) (sshv2 !) | 482 sending upgrade request: * proto=exp-ssh-v2-0003 (glob) (sshv2 !) |
483 sending hello command | 483 sending hello command |
484 sending between command | 484 sending between command |
485 remote: 427 (sshv1 !) | 485 remote: 427 (sshv1 !) |
486 protocol upgraded to exp-ssh-v2-0002 (sshv2 !) | 486 protocol upgraded to exp-ssh-v2-0003 (sshv2 !) |
487 remote: capabilities: batch branchmap $USUAL_BUNDLE2_CAPS$ changegroupsubset getbundle known lookup protocaps pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash | 487 remote: capabilities: batch branchmap $USUAL_BUNDLE2_CAPS$ changegroupsubset getbundle known lookup protocaps pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash |
488 remote: 1 (sshv1 !) | 488 remote: 1 (sshv1 !) |
489 sending protocaps command | 489 sending protocaps command |
490 preparing listkeys for "bookmarks" | 490 preparing listkeys for "bookmarks" |
491 sending listkeys command | 491 sending listkeys command |