comparison contrib/check-code.py @ 29279:438caf194160

check-code: make repquote distinguish more characters for exact detection

This patch makes repquote() distinguish more characters below, as a
preparation for exact detection in subsequent patch.

  - "%"  as "%"
  - "\\" as "b"(ackslash)
  - "*"  as "A"(sterisk)
  - "+"  as "P"(lus)
  - "-"  as "M"(inus)

Characters other than "%" don't use itself as replacement, because
they are treated as special ones in regexp.

29278:5eda83fb09fc

    return re.compile(pat)

def repquote(m):
    # check "rules depending on implementation of repquote()" in each
    # patterns (especially pypats), before changing this function
    fixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q'}
    def encodechr(i):
        if i > 255:
            return 'u'
        c = chr(i)
        if c in fixedmap:

    (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
    (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
    (r'\.next\(\)', "don't use .next(), use next(...)"),

    # rules depending on implementation of repquote()
    (r' x+[xpqo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),
    (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
     "missing _() in ui message (use () to hide false-positives)"),
  ],
  # warnings
  [

29279:438caf194160

    return re.compile(pat)

def repquote(m):
    # check "rules depending on implementation of repquote()" in each
    # patterns (especially pypats), before changing this function
    fixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q',
                '%': '%', '\\': 'b', '*': 'A', '+': 'P', '-': 'M'}
    def encodechr(i):
        if i > 255:
            return 'u'
        c = chr(i)
        if c in fixedmap:

    (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
    (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
    (r'\.next\(\)', "don't use .next(), use next(...)"),

    # rules depending on implementation of repquote()
    (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',
     'string join across lines with no space'),
    (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
     "missing _() in ui message (use () to hide false-positives)"),
  ],
  # warnings
  [