comparison mercurial/localrepo.py @ 22909:4545c5b53013

commit: use separate variable for p1 manifest and new manifest

In localrepo.commitctx(), p1's manifest is copied and used as the
basis for the manifest that is about to be committed. The way the copy
is updated makes it safe to use it where the original p1's manifest is
wanted. For readability, though, a separate variable for each purpose
would be clearer. Make it so.

22908:71570f310417

        try:
            tr = self.transaction("commit")
            trp = weakref.proxy(tr)

            if ctx.files():
                m1 = p1.manifest().copy()
                m2 = p2.manifest()

                # check in files
                new = {}
                changed = []
                removed = list(ctx.removed())

                        if fctx is None:
                            removed.append(f)
                        else:
                            new[f] = self._filecommit(fctx, m1, m2, linkrev,
                                                      trp, changed)
                            m1.set(f, fctx.flags())
                    except OSError, inst:
                        self.ui.warn(_("trouble committing %s!\n") % f)
                        raise
                    except IOError, inst:
                        errcode = getattr(inst, 'errno', errno.ENOENT)
                        if error or errcode and errcode != errno.ENOENT:
                            self.ui.warn(_("trouble committing %s!\n") % f)
                        raise

                # update manifest
                m1.update(new)
                removed = [f for f in sorted(removed) if f in m1 or f in m2]
                drop = [f for f in removed if f in m1]
                for f in drop:
                    del m1[f]
                mn = self.manifest.add(m1, trp, linkrev, p1.manifestnode(),
                                       p2.manifestnode(), new, drop)
                files = changed + removed
            else:
                mn = p1.manifestnode()
                files = []

22909:4545c5b53013

        try:
            tr = self.transaction("commit")
            trp = weakref.proxy(tr)

            if ctx.files():
                m1 = p1.manifest()
                m2 = p2.manifest()
                m = m1.copy()

                # check in files
                new = {}
                changed = []
                removed = list(ctx.removed())

                        if fctx is None:
                            removed.append(f)
                        else:
                            new[f] = self._filecommit(fctx, m1, m2, linkrev,
                                                      trp, changed)
                            m.set(f, fctx.flags())
                    except OSError, inst:
                        self.ui.warn(_("trouble committing %s!\n") % f)
                        raise
                    except IOError, inst:
                        errcode = getattr(inst, 'errno', errno.ENOENT)
                        if error or errcode and errcode != errno.ENOENT:
                            self.ui.warn(_("trouble committing %s!\n") % f)
                        raise

                # update manifest
                m.update(new)
                removed = [f for f in sorted(removed) if f in m1 or f in m2]
                drop = [f for f in removed if f in m]
                for f in drop:
                    del m[f]
                mn = self.manifest.add(m, trp, linkrev,
                                       p1.manifestnode(), p2.manifestnode(),
                                       new, drop)
                files = changed + removed
            else:
                mn = p1.manifestnode()
                files = []