comparison mercurial/revlog.py @ 21750:4ab287c2d337 stable

revlog: hold a private reference to self._cache

This keeps other threads from modifying self._cache out from under us.
With this and the previous fix, 'hg serve' survives 100k hits with siege.

21749:f13728d59c0e

            node = self.node(rev)
        else:
            node = nodeorrev
            rev = None

        cachedrev = None
        if node == nullid:
            return ""
        if self._cache:
            if self._cache[0] == node:
                return self._cache[2]
            cachedrev = self._cache[1]

        # look up what we need to read
        text = None
        if rev is None:
            rev = self.rev(node)

                iterrev -= 1
            e = index[iterrev]

        if iterrev == cachedrev:
            # cache hit
            text = self._cache[2]
        else:
            chain.append(iterrev)
        chain.reverse()

        # drop cache to save memory

21750:4ab287c2d337

            node = self.node(rev)
        else:
            node = nodeorrev
            rev = None

        _cache = self._cache # grab local copy of cache to avoid thread race
        cachedrev = None
        if node == nullid:
            return ""
        if _cache:
            if _cache[0] == node:
                return _cache[2]
            cachedrev = _cache[1]

        # look up what we need to read
        text = None
        if rev is None:
            rev = self.rev(node)

                iterrev -= 1
            e = index[iterrev]

        if iterrev == cachedrev:
            # cache hit
            text = _cache[2]
        else:
            chain.append(iterrev)
        chain.reverse()

        # drop cache to save memory