comparison mercurial/hgweb/hgweb_mod.py @ 36887:4daa22071d5d

hgweb: stop passing req and tmpl into @webcommand functions (API)

We have effectively removed all consumers of the old wsgirequest
type. The templater can be accessed on the requestcontext passed
into the @webcommand function.

For the most part, these arguments are unused. They only exist to
provide backwards compatibility. And in the case of wsgirequest,
use of that object could actively interfere with the new request
object.

So let's stop passing these objects to @webcommand functions.

With this commit, wsgirequest is practically dead from the hgweb
WSGI application. There are still some uses in hgwebdir though...

.. api::

   @webcommand functions now only receive a single argument. The
   request and templater instances can be accessed via the
   ``req`` and ``templater`` attributes of the first argument.
   Note that the request object is different from previous Mercurial
   releases and consumers of the previous ``req`` 2nd argument
   will need updating to use the new API.

Differential Revision: https://phab.mercurial-scm.org/D2803

36886:563fd95a6efb

            else:
                # Set some globals appropriate for web handlers. Commands can
                # override easily enough.
                res.status = '200 Script output follows'
                res.headers['Content-Type'] = ctype
                return getattr(webcommands, cmd)(rctx, wsgireq, rctx.tmpl)

        except (error.LookupError, error.RepoLookupError) as err:
            msg = pycompat.bytestr(err)
            if (util.safehasattr(err, 'name') and
                not isinstance(err,  error.ManifestLookupError)):

36887:4daa22071d5d

            else:
                # Set some globals appropriate for web handlers. Commands can
                # override easily enough.
                res.status = '200 Script output follows'
                res.headers['Content-Type'] = ctype
                return getattr(webcommands, cmd)(rctx)

        except (error.LookupError, error.RepoLookupError) as err:
            msg = pycompat.bytestr(err)
            if (util.safehasattr(err, 'name') and
                not isinstance(err,  error.ManifestLookupError)):