Mercurial > hg
comparison tests/test-largefiles-misc.t @ 23183:51c9196a6bd0
largefiles: remove meaningless code path for "hg pull --rebase"
This patch removes "--rebase" specific code path for "hg pull" in
"overridepull", because previous patch makes it meaningless: now,
"rebase.rebase" ("orig" invocation in this patch) can
update/commit largefiles safely without "repo._isrebasing = True".
As a side effect of removing "rebase.rebase" invocation in
"overridepull", this patch removes "nothing to rebase ..." message in
"test-largefiles.t", which is shown only when rebase extension is
enabled AFTER largefiles:
before this patch:
1. "dispatch" invokes "pullrebase" of rebase as "hg pull" at
first, because rebase wraps "hg pull" later
2. "pullrebase" invokes "overridepull" of largefiles as "orig",
even though rebase assumes that "orig" is "pull" of commands
3. "overridepull" executes "pull" and "rebase" directly
3.1 "pull" pulls changesets and creates new head "X"
3.2 "rebase" rebases current working parent "Y" on "X"
4. "overridepull" returns to "pullrebase"
5. "pullrebase" tries to rebase, but there is nothing to be done,
because "Y" is already rebased on "X". then, it shows "nothing
to rebase ..."
after this patch:
1. "dispatch" invokes "pullrebase" of rebase as "hg pull"
2. "pullrebase" invokes "overridepull" of largefiles as "orig"
3. "overridepull" executes "pull" as "orig"
4. "overridepull" returns to "pullrebase"
5. revision "Y" is not yet rebased, so "pullrebase" doesn't shows
"nothing to rebase ..."
As another side effect of removing "rebase.rebase" invocation, this
patch fixes issue3861, which occurs only when rebase extension is
enabled BEFORE largefiles:
before this patch:
1. "dispatch" invokes "overridepull" of largefiles at first,
because largefiles wrap "hg pull" later
2. "overridepull" executes "pull" and "rebase" explicitly
2.1 "pull" pulls changesets and creates new head "X"
2.2 "rebase" rebases current working parent, but fails because
no revision is checked out in issue3861 case
3. "overridepull" returns to "dispatch" with exit code 1 returned
from "rebase" at (2.2)
4. "hg pull" terminates with exit code 1 unexpectedly
after this patch:
1. "dispatch" invokes "overridepull" of largefiles at first
2. "overridepull" invokes "pullrebase" of rebase as "orig"
3. "pullrebase" invokes "pull" as "orig"
4. "pullrebase" invokes "rebase", and it fails
5. "pullrebase" returns to "overridepull" with exit code 0
(because "pullrebase" ignores result of "pull" and "rebase")
6. "overridepull" returns to "dispatch" with exit code 0 returned
from "rebase" at (5)
7. "hg pull" terminates with exit code 0
author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
---|---|
date | Wed, 05 Nov 2014 23:24:47 +0900 |
parents | e53f6b72a0e4 |
children | bbe56e07e07a |
comparison
equal
deleted
inserted
replaced
23182:9b6c3947b4a7 | 23183:51c9196a6bd0 |
---|---|
830 #endif | 830 #endif |
831 | 831 |
832 $ cd .. | 832 $ cd .. |
833 | 833 |
834 | 834 |
835 | 835 Test "pull --rebase" when rebase is enabled before largefiles (issue3861) |
836 ========================================================================= | |
837 | |
838 $ hg showconfig extensions | grep largefiles | |
839 extensions.largefiles=! | |
840 | |
841 $ mkdir issue3861 | |
842 $ cd issue3861 | |
843 $ hg init src | |
844 $ hg clone -q src dst | |
845 $ echo a > src/a | |
846 $ hg -R src commit -Aqm "#0" | |
847 Invoking status precommit hook | |
848 A a | |
849 | |
850 $ cat >> dst/.hg/hgrc <<EOF | |
851 > [extensions] | |
852 > largefiles= | |
853 > EOF | |
854 $ hg -R dst pull --rebase | |
855 pulling from $TESTTMP/issue3861/src (glob) | |
856 requesting all changes | |
857 adding changesets | |
858 adding manifests | |
859 adding file changes | |
860 added 1 changesets with 1 changes to 1 files | |
861 nothing to rebase - working directory parent is already an ancestor of destination bf5e395ced2c | |
862 1 files updated, 0 files merged, 0 files removed, 0 files unresolved | |
863 | |
864 $ cd .. |