comparison rust/hg-cpython/src/dirstate/dirstate_map.rs @ 42799:5399532510ae

rust: simply use TryInto to convert slice to array

Since our rust module depends on TryInto, there's no point to avoid using it.

While rewriting copy_into_array(), I noticed CPython interface doesn't check
the length of the p1/p2 values, which is marked as TODO.

42798:99dff4264524

    dirstate::copymap::{CopyMap, CopyMapItemsIterator, CopyMapKeysIterator},
    dirstate::{decapsule_make_dirstate_tuple, dirs_multiset::Dirs},
    ref_sharing::PySharedState,
};
use hg::{
    utils::copy_into_array, DirsIterable, DirsMultiset, DirstateEntry,
    DirstateMap as RustDirstateMap, DirstateParents, DirstateParseError,
    EntryState,
};

// TODO

                ))
            })
    }

    def setparents(&self, p1: PyObject, p2: PyObject) -> PyResult<PyObject> {
        let p1 = copy_into_array(p1.extract::<PyBytes>(py)?.data(py));
        let p2 = copy_into_array(p2.extract::<PyBytes>(py)?.data(py));

        self.inner(py)
            .borrow_mut()
            .set_parents(DirstateParents { p1, p2 });
        Ok(py.None())

        p2: PyObject,
        now: PyObject
    ) -> PyResult<PyBytes> {
        let now = Duration::new(now.extract(py)?, 0);
        let parents = DirstateParents {
            p1: copy_into_array(p1.extract::<PyBytes>(py)?.data(py)),
            p2: copy_into_array(p2.extract::<PyBytes>(py)?.data(py)),
        };

        match self.borrow_mut(py)?.pack(parents, now) {
            Ok(packed) => Ok(PyBytes::new(py, &packed)),
            Err(_) => Err(PyErr::new::<exc::OSError, _>(

42799:5399532510ae

    dirstate::copymap::{CopyMap, CopyMapItemsIterator, CopyMapKeysIterator},
    dirstate::{decapsule_make_dirstate_tuple, dirs_multiset::Dirs},
    ref_sharing::PySharedState,
};
use hg::{
    DirsIterable, DirsMultiset, DirstateEntry,
    DirstateMap as RustDirstateMap, DirstateParents, DirstateParseError,
    EntryState,
};

// TODO

                ))
            })
    }

    def setparents(&self, p1: PyObject, p2: PyObject) -> PyResult<PyObject> {
        // TODO: don't panic; raise Python exception instead.
        let p1 = p1.extract::<PyBytes>(py)?.data(py).try_into().unwrap();
        let p2 = p2.extract::<PyBytes>(py)?.data(py).try_into().unwrap();

        self.inner(py)
            .borrow_mut()
            .set_parents(DirstateParents { p1, p2 });
        Ok(py.None())

        p2: PyObject,
        now: PyObject
    ) -> PyResult<PyBytes> {
        let now = Duration::new(now.extract(py)?, 0);
        let parents = DirstateParents {
            // TODO: don't panic; raise Python exception instead.
            p1: p1.extract::<PyBytes>(py)?.data(py).try_into().unwrap(),
            p2: p2.extract::<PyBytes>(py)?.data(py).try_into().unwrap(),
        };

        match self.borrow_mut(py)?.pack(parents, now) {
            Ok(packed) => Ok(PyBytes::new(py, &packed)),
            Err(_) => Err(PyErr::new::<exc::OSError, _>(