comparison mercurial/localrepo.py @ 23416:53a65929ef1f stable

pushkey: gracefully handle prepushkey hook failure (issue4455)

This allow to gracefully report the failure of the bookmark push and carry on.
Before this change set. Local push would plain quit and wireprotocol would
failed in various ungraceful way.

23415:cdbb85489c41

        finally:
            self.ui.restoreconfig(quiet)
        return ret

    def pushkey(self, namespace, key, old, new):
        self.hook('prepushkey', throw=True, namespace=namespace, key=key,
                  old=old, new=new)
        self.ui.debug('pushing key for "%s:%s"\n' % (namespace, key))
        ret = pushkey.push(self, namespace, key, old, new)
        self.hook('pushkey', namespace=namespace, key=key, old=old, new=new,
                  ret=ret)
        return ret

23416:53a65929ef1f

        finally:
            self.ui.restoreconfig(quiet)
        return ret

    def pushkey(self, namespace, key, old, new):
        try:
            self.hook('prepushkey', throw=True, namespace=namespace, key=key,
                      old=old, new=new)
        except error.HookAbort, exc:
            self.ui.write_err(_("pushkey-abort: %s\n") % exc)
            if exc.hint:
                self.ui.write_err(_("(%s)\n") % exc.hint)
            return False
        self.ui.debug('pushing key for "%s:%s"\n' % (namespace, key))
        ret = pushkey.push(self, namespace, key, old, new)
        self.hook('pushkey', namespace=namespace, key=key, old=old, new=new,
                  ret=ret)
        return ret