comparison tests/test-rename.t @ 39350:5b92a717bfc1

rename: return error status if any rename/copy failed

Ever since 447ea621e50e (copy: propagate errors properly, 2007-12-06),
we have returned an error status if the source file did not
exist. That commit did not return error status for any other errors,
and it's unclear if that was on purpose or not. It seems to me like we
should return an error in the other cases to, so that's what this
patch does.

Differential Revision: https://phab.mercurial-scm.org/D4419

39349:534e451b6dda

rename --after a single file to a nonexistent target filename

  $ hg rename --after d1/a dummy
  d1/a: not recording move - dummy does not exist

move a single file to an existing directory

  $ hg rename d1/d11/a1 d2
  $ hg status -C

  $ hg rename d1/* d2
  d2/b: not overwriting - file already committed
  ('hg rename --force' to replace the file by recording a rename)
  moving d1/d11/a1 to d2/d11/a1
  $ hg status -C
  A d2/a
    d1/a
  A d2/ba
    d1/ba

  $ hg rename --after 'glob:d1/**' d2/d21
  moving d1/a to d2/d21/a
  d1/b: not recording move - d2/d21/b does not exist
  d1/ba: not recording move - d2/d21/ba does not exist
  moving d1/d11/a1 to d2/d21/a1
  $ hg status -C
  A d2/d21/a
    d1/a
  A d2/d21/a1
    d1/d11/a1

  $ echo "ca" > d1/ca
  $ hg rename d1/ba d1/ca
  d1/ca: not overwriting - file exists
  ('hg rename --after' to record the rename)
  $ hg status -C
  ? d1/ca
  $ hg update -C
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

#if symlink
  $ ln -s ba d1/ca
  $ hg rename --traceback d1/ba d1/ca
  d1/ca: not overwriting - file exists
  ('hg rename --after' to record the rename)
  $ hg status -C
  ? d1/ca
  $ hg update -C
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ rm d1/ca

  $ mkdir d3
  $ hg rename d1/* d2/* d3
  moving d1/d11/a1 to d3/d11/a1
  d3/b: not overwriting - d2/b collides with d1/b
  $ hg status -C
  A d3/a
    d1/a
  A d3/b
    d1/b

39350:5b92a717bfc1

rename --after a single file to a nonexistent target filename

  $ hg rename --after d1/a dummy
  d1/a: not recording move - dummy does not exist
  [1]

move a single file to an existing directory

  $ hg rename d1/d11/a1 d2
  $ hg status -C

  $ hg rename d1/* d2
  d2/b: not overwriting - file already committed
  ('hg rename --force' to replace the file by recording a rename)
  moving d1/d11/a1 to d2/d11/a1
  [1]
  $ hg status -C
  A d2/a
    d1/a
  A d2/ba
    d1/ba

  $ hg rename --after 'glob:d1/**' d2/d21
  moving d1/a to d2/d21/a
  d1/b: not recording move - d2/d21/b does not exist
  d1/ba: not recording move - d2/d21/ba does not exist
  moving d1/d11/a1 to d2/d21/a1
  [1]
  $ hg status -C
  A d2/d21/a
    d1/a
  A d2/d21/a1
    d1/d11/a1

  $ echo "ca" > d1/ca
  $ hg rename d1/ba d1/ca
  d1/ca: not overwriting - file exists
  ('hg rename --after' to record the rename)
  [1]
  $ hg status -C
  ? d1/ca
  $ hg update -C
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

#if symlink
  $ ln -s ba d1/ca
  $ hg rename --traceback d1/ba d1/ca
  d1/ca: not overwriting - file exists
  ('hg rename --after' to record the rename)
  [1]
  $ hg status -C
  ? d1/ca
  $ hg update -C
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ rm d1/ca

  $ mkdir d3
  $ hg rename d1/* d2/* d3
  moving d1/d11/a1 to d3/d11/a1
  d3/b: not overwriting - d2/b collides with d1/b
  [1]
  $ hg status -C
  A d3/a
    d1/a
  A d3/b
    d1/b