comparison hgext/lfs/__init__.py @ 48116:5ced12cfa41b

errors: raise InputError on bad revset to revrange() iff provided by the user Most callers of `scmutil.revrange()` pass in a revset provided by the user. If there are problems resolving that, it should result in an `InputError` and exit code 10 (when using detailed exit codes). However, there are also some callers that pass in revsets not provided by the user. `InputError` is not appropriate in those cases. This patch therefore introduces a wrapper around `scmutil.revrange()` that simply converts the exception type. I put it in `logcmdutil.py` since that seems to be the lowest-level module in the (poorly defined) UI layer. Differential Revision: https://phab.mercurial-scm.org/D11560
author Martin von Zweigbergk <martinvonz@google.com>
date Tue, 28 Sep 2021 08:47:11 -0700
parents 59fa3890d40a
children bf424fe4f814
comparison
equal deleted inserted replaced
48115:b067d22dc6ad 48116:5ced12cfa41b
135 extensions, 135 extensions,
136 exthelper, 136 exthelper,
137 filelog, 137 filelog,
138 filesetlang, 138 filesetlang,
139 localrepo, 139 localrepo,
140 logcmdutil,
140 minifileset, 141 minifileset,
141 pycompat, 142 pycompat,
142 revlog, 143 revlog,
143 scmutil, 144 scmutil,
144 templateutil, 145 templateutil,
415 [(b'r', b'rev', [], _(b'upload large files introduced by REV'))], 416 [(b'r', b'rev', [], _(b'upload large files introduced by REV'))],
416 ) 417 )
417 def debuglfsupload(ui, repo, **opts): 418 def debuglfsupload(ui, repo, **opts):
418 """upload lfs blobs added by the working copy parent or given revisions""" 419 """upload lfs blobs added by the working copy parent or given revisions"""
419 revs = opts.get('rev', []) 420 revs = opts.get('rev', [])
420 pointers = wrapper.extractpointers(repo, scmutil.revrange(repo, revs)) 421 pointers = wrapper.extractpointers(repo, logcmdutil.revrange(repo, revs))
421 wrapper.uploadblobs(repo, pointers) 422 wrapper.uploadblobs(repo, pointers)
422 423
423 424
424 @eh.wrapcommand( 425 @eh.wrapcommand(
425 b'verify', 426 b'verify',