comparison hgext/patchbomb.py @ 48116:5ced12cfa41b

errors: raise InputError on bad revset to revrange() iff provided by the user

Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.

Differential Revision: https://phab.mercurial-scm.org/D11560

48115:b067d22dc6ad

    commands,
    encoding,
    error,
    formatter,
    hg,
    mail,
    patch,
    pycompat,
    registrar,
    scmutil,

    elif bookmark:
        if bookmark not in repo._bookmarks:
            raise error.Abort(_(b"bookmark '%s' not found") % bookmark)
        revs = scmutil.bookmarkrevs(repo, bookmark)

    revs = scmutil.revrange(repo, revs)
    if outgoing:
        revs = _getoutgoing(repo, dest, revs)
    if bundle:
        opts[b'revs'] = [b"%d" % r for r in revs]

48116:5ced12cfa41b

    commands,
    encoding,
    error,
    formatter,
    hg,
    logcmdutil,
    mail,
    patch,
    pycompat,
    registrar,
    scmutil,

    elif bookmark:
        if bookmark not in repo._bookmarks:
            raise error.Abort(_(b"bookmark '%s' not found") % bookmark)
        revs = scmutil.bookmarkrevs(repo, bookmark)

    revs = logcmdutil.revrange(repo, revs)
    if outgoing:
        revs = _getoutgoing(repo, dest, revs)
    if bundle:
        opts[b'revs'] = [b"%d" % r for r in revs]