comparison hgext/mq.py @ 19812:5d6cfdc38a3d

mq: simplifies the refresh hint in checklocalchanges

The `checklocalchanges` function in the `mq.queue` class takes a `refresh` argument that
changes the error message of raised exception. When refresh is
`True` the exception message is "local changes found, refresh first" otherwise,
the message is just "local changes found".

This changeset is the first of a series that extract `strip` into a standalone
extension (as discussed in issue3824). This `checklocalchanges` function is
indirectly used by the strip command. But in a standalone strip extension the
concept of "refresh first" has no sense. In practice, When used in the context
of the strip commands `refresh`'s value is always `False`.

So my final goal is a be able to extract the `checklocalchanges` logic in a
standalone extension but to keep the part related to "refresh first" in the mq
extension. However the refresh handling is deeply entangled into the
`checklocalchanges` code. It is handled as low a possible at the point we raise
the exception.

So we moves handling of refresh upper in the `checklocalchanges` code. This will
allow the extraction of a simple version in the strip extension while mq can
still inject its logic when needed.

Two helper functions `localchangesfound` and `localchangedsubreposfound` died in
the process they are replaced by simple raise lines.

19811:5e10d41e7b9c

        elif substatestate in 'r':
            changes[2].append('.hgsubstate')
        else: # modified
            changes[0].append('.hgsubstate')

    def localchangesfound(self, refresh=True):
        if refresh:
            raise util.Abort(_("local changes found, refresh first"))
        else:
            raise util.Abort(_("local changes found"))

    def localchangedsubreposfound(self, refresh=True):
        if refresh:
            raise util.Abort(_("local changed subrepos found, refresh first"))
        else:
            raise util.Abort(_("local changed subrepos found"))

    def checklocalchanges(self, repo, force=False, refresh=True):
        cmdutil.checkunfinished(repo)
        m, a, r, d = repo.status()[:4]
        if not force:
            if (m or a or r or d):
                self.localchangesfound(refresh)
            if self.checksubstate(repo):
                self.localchangedsubreposfound(refresh)
        return m, a, r, d

    _reserved = ('series', 'status', 'guards', '.', '..')
    def checkreservedname(self, name):
        if name in self._reserved:

                if d:
                    raise util.Abort(_("deletions found between repo revs"))

                tobackup = set(a + m + r) & tobackup
                if keepchanges and tobackup:
                    self.localchangesfound()
                self.backup(repo, tobackup)

                for f in a:
                    util.unlinkpath(repo.wjoin(f), ignoremissing=True)
                    repo.dirstate.drop(f)

19812:5d6cfdc38a3d

        elif substatestate in 'r':
            changes[2].append('.hgsubstate')
        else: # modified
            changes[0].append('.hgsubstate')

    def checklocalchanges(self, repo, force=False, refresh=True):
        excsuffix = ''
        if refresh:
            excsuffix = ', refresh first'
            # plain versions for i18n tool to detect them
            _("local changes found, refresh first")
            _("local changed subrepos found, refresh first")
        cmdutil.checkunfinished(repo)
        m, a, r, d = repo.status()[:4]
        if not force:
            if (m or a or r or d):
                _("local changes found") # i18n tool detection
                raise util.Abort(_("local changes found" + excsuffix))
            if self.checksubstate(repo):
                _("local changed subrepos found") # i18n tool detection
                raise util.Abort(_("local changed subrepos found" + excsuffix))
        return m, a, r, d

    _reserved = ('series', 'status', 'guards', '.', '..')
    def checkreservedname(self, name):
        if name in self._reserved:

                if d:
                    raise util.Abort(_("deletions found between repo revs"))

                tobackup = set(a + m + r) & tobackup
                if keepchanges and tobackup:
                    raise util.Abort(_("local changes found, refresh first"))
                self.backup(repo, tobackup)

                for f in a:
                    util.unlinkpath(repo.wjoin(f), ignoremissing=True)
                    repo.dirstate.drop(f)