comparison tests/run-tests.py @ 21614:609a642dff61

run-tests: write .err files earlier

Earlier refactoring of run-tests.py accidentally broke --interactive
and external diff generation by not having .err files written before
they are consulted. This patch fixes that.

21613:b3213b9fafed

        elif ret == 'timeout':
            self.fail('timed out')
        elif ret is False:
            raise WarnTest('no result code from test')
        elif out != self._refout:
            # The result object handles diff calculation for us.
            self._result.addOutputMismatch(self, ret, out, self._refout)

            if ret:
                msg = 'output changed and ' + describe(ret)
            else:
                msg = 'output changed'

            if (ret != 0 or out != self._refout) and not self._skipped \
                and not self._debug:
                f = open(self.errpath, 'wb')
                for line in out:
                    f.write(line)
            f.close()

            self.fail(msg)
        elif ret:
            self.fail(describe(ret))

21614:609a642dff61

        elif ret == 'timeout':
            self.fail('timed out')
        elif ret is False:
            raise WarnTest('no result code from test')
        elif out != self._refout:
            # Diff generation may rely on written .err file.
            if (ret != 0 or out != self._refout) and not self._skipped \
                and not self._debug:
                f = open(self.errpath, 'wb')
                for line in out:
                    f.write(line)
                f.close()

            # The result object handles diff calculation for us.
            self._result.addOutputMismatch(self, ret, out, self._refout)

            if ret:
                msg = 'output changed and ' + describe(ret)
            else:
                msg = 'output changed'

            self.fail(msg)
        elif ret:
            self.fail(describe(ret))