comparison mercurial/util.py @ 33657:60ee7af2a2ba stable

subrepo: add tests for svn rogue ssh urls (SEC)

'ssh://' has an exploit that will pass the url blindly to the ssh
command, allowing a malicious person to have a subrepo with
'-oProxyCommand' which could run arbitrary code on a user's machine. In
addition, at least on Windows, a pipe '|' is able to execute arbitrary
commands.

When this happens, let's throw a big abort into the user's face so that
they can inspect what's going on.

33656:475af2f89636

    user.

    Raises an error.Abort when the url is unsafe.
    """
    path = urlreq.unquote(path)
    if path.startswith('ssh://-') or '|' in path:
        raise error.Abort(_('potentially unsafe url: %r') %
                          (path,))

def hidepassword(u):
    '''hide user credential in a url string'''

33657:60ee7af2a2ba

    user.

    Raises an error.Abort when the url is unsafe.
    """
    path = urlreq.unquote(path)
    if (path.startswith('ssh://-') or path.startswith('svn+ssh://-')
        or '|' in path):
        raise error.Abort(_('potentially unsafe url: %r') %
                          (path,))

def hidepassword(u):
    '''hide user credential in a url string'''