comparison mercurial/localrepo.py @ 31706:63d4deda1b31

tags: do not feed dictionaries to 'findglobaltags'

The code asserts that these dictionary are empty. So we can be more explicit
and have the function return the dictionaries directly.

31705:5eb4d206202b

        # mq and bookmarks add tags, but do not set the tagtype at all.
        # Should each extension invent its own tag type?  Should there
        # be one tagtype for all such "virtual" tags?  Or is the status
        # quo fine?

        alltags = {}                    # map tag name to (node, hist)
        tagtypes = {}

        tagsmod.findglobaltags(self.ui, self, alltags, tagtypes)
        tagsmod.readlocaltags(self.ui, self, alltags, tagtypes)

        # Build the return dicts.  Have to re-encode tag names because
        # the tags module always uses UTF-8 (in order not to lose info
        # writing to the cache), but the rest of Mercurial wants them in

31706:63d4deda1b31

        # mq and bookmarks add tags, but do not set the tagtype at all.
        # Should each extension invent its own tag type?  Should there
        # be one tagtype for all such "virtual" tags?  Or is the status
        # quo fine?


        globaldata = tagsmod.findglobaltags(self.ui, self)
        alltags = globaldata[0]   # map tag name to (node, hist)
        tagtypes = globaldata[1]  # map tag name to tag type

        tagsmod.readlocaltags(self.ui, self, alltags, tagtypes)

        # Build the return dicts.  Have to re-encode tag names because
        # the tags module always uses UTF-8 (in order not to lose info
        # writing to the cache), but the rest of Mercurial wants them in