comparison hgext/convert/cvs.py @ 22296:650b5b6e75ed

convert: use None value for missing files instead of overloading IOError The internal API used IOError to indicate that a file should be marked as removed. There is some correlation between IOError (especially with ENOENT) and files that should be removed, but using IOErrors to represent file removal internally required some hacks. Instead, use the value None to indicate that the file not is present. Before, spurious IO errors could cause commits that silently removed files. They will now be reported like all other IO errors so the root cause can be fixed.
author Mads Kiilerich <madski@unity3d.com>
date Tue, 26 Aug 2014 22:03:32 +0200
parents 337d728e644f
children 35ab037de989
comparison
equal deleted inserted replaced
22295:926bc0d3b595 22296:650b5b6e75ed
218 output.write(data) 218 output.write(data)
219 return output.getvalue() 219 return output.getvalue()
220 220
221 self._parse() 221 self._parse()
222 if rev.endswith("(DEAD)"): 222 if rev.endswith("(DEAD)"):
223 raise IOError 223 return None, None
224 224
225 args = ("-N -P -kk -r %s --" % rev).split() 225 args = ("-N -P -kk -r %s --" % rev).split()
226 args.append(self.cvsrepo + '/' + name) 226 args.append(self.cvsrepo + '/' + name)
227 for x in args: 227 for x in args:
228 self.writep.write("Argument %s\n" % x) 228 self.writep.write("Argument %s\n" % x)