comparison tests/test-lfs-test-server.t @ 37242:67db84842356

lfs: improve the client message when the server signals an object error

Two things here.  First, the previous message included a snippet of JSON, which
tends to be long (and in the case of lfs-test-server, has no error message).
Instead, give a concise message where possible, and leave the JSON to a debug
output.  Second, the server can signal issues other than a missing individual
file.  This change shows a corrupt file, but I'm debating letting the corrupt
file get downloaded, because 1) the error code doesn't really fit, and 2) having
it locally makes forensics easier.  Maybe need a config knob for that.

37241:79af9ae46a78

  Status: 200 (git-server !)
  Content-Length: 7 (git-server !)
  Content-Type: text/plain; charset=utf-8 (git-server !)
  Date: $HTTP_DATE$ (git-server !)
  abort: corrupt remote lfs object: d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 (git-server !)
  abort: LFS server error. Remote object for "c" not found: *! (glob) (hg-server !)
  [255]

The corrupted blob is not added to the usercache or local store

  $ test -f ../repo1/.hg/store/lfs/objects/d1/1e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998

        "size": 6
      }
    ]
    "transfer": "basic" (hg-server !)
  }
  abort: LFS server error. Remote object for "b" not found:(.*)! (re)
  [255]

Check error message when object does not exist:

  $ cd $TESTTMP

        "size": 6
      }
    ]
    "transfer": "basic" (hg-server !)
  }
  abort: LFS server error. Remote object for "a" not found:(.*)! (re)
  [255]

  $ $PYTHON $RUNTESTDIR/killdaemons.py $DAEMON_PIDS

37242:67db84842356

  Status: 200 (git-server !)
  Content-Length: 7 (git-server !)
  Content-Type: text/plain; charset=utf-8 (git-server !)
  Date: $HTTP_DATE$ (git-server !)
  abort: corrupt remote lfs object: d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 (git-server !)
  abort: LFS server error for "c": Validation error! (hg-server !)
  [255]

The corrupted blob is not added to the usercache or local store

  $ test -f ../repo1/.hg/store/lfs/objects/d1/1e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998

        "size": 6
      }
    ]
    "transfer": "basic" (hg-server !)
  }
  abort: LFS server error for "b": The object does not exist!
  [255]

Check error message when object does not exist:

  $ cd $TESTTMP

        "size": 6
      }
    ]
    "transfer": "basic" (hg-server !)
  }
  abort: LFS server error for "a": The object does not exist!
  [255]

  $ $PYTHON $RUNTESTDIR/killdaemons.py $DAEMON_PIDS