comparison tests/test-convert-svn-encoding.t @ 45020:697212a830fb stable

convert: bail out in Subversion source if encountering non-ASCII HTTP(S) URL

Before this patch, in the tested case, urllib raised `httplib.InvalidURL: URL
can't contain control characters. '/\xff/!svn/ver/0/.svn' (found at least
'\xff')`, which resulted in that the URL was never recognized as a Subversion
repository.

This patch adds a check that bails out if the URL contains non-ASCII characters.
The warning is not overly user-friendly, but giving the user something to type
into a search engine is definitively better than not explaining why the
repository was not recognized.

We could support non-ASCII chracters by quoting them before passing them to
urllib. However, we would want to be compatible with what the `svn` command
does, which converts the URL from the locale encoding to UTF-8, percent-encodes
it and sends it to the server. If the locale encoding is not UTF-8, the
behavior is IMHO not very intuitive, as the `svn` command may send different
(percent-encoded) octets than what was passed on the console. Instead of
copying this behavior, we better leave it forbidden.

45013:bd0f122f3f51

  e94e4422020e715add80525e8f0f46c9968689f1 branch\xc3\xa9e (esc)
  f7e66f98380ed1e53a797c5c7a7a2616a7ab377d branch\xc3\xa9 (esc)

  $ cd ..

#if py3
For now, on Python 3, we abort when encountering non-UTF-8 percent-encoded
bytes in a filename.

  $ hg convert file:///%ff test

45020:697212a830fb

  e94e4422020e715add80525e8f0f46c9968689f1 branch\xc3\xa9e (esc)
  f7e66f98380ed1e53a797c5c7a7a2616a7ab377d branch\xc3\xa9 (esc)

  $ cd ..

Subversion sources don't support non-ASCII characters in HTTP(S) URLs.

  $ XFF=$($PYTHON -c 'from mercurial.utils.procutil import stdout; stdout.write(b"\xff")')
  $ hg convert --source-type=svn http://localhost:$HGPORT/$XFF test
  initializing destination test repository
  Subversion sources don't support non-ASCII characters in HTTP(S) URLs. Please percent-encode them.
  http://localhost:$HGPORT/\xff does not look like a Subversion repository (esc)
  abort: http://localhost:$HGPORT/\xff: missing or unsupported repository (esc)
  [255]

#if py3
For now, on Python 3, we abort when encountering non-UTF-8 percent-encoded
bytes in a filename.

  $ hg convert file:///%ff test