comparison tests/test-wireproto-command-changesetdata.t @ 40175:6c42409691ec

wireprotov2: stop sending phase updates for base revisions This feature is broken and doesn't work properly in all scenarios. e.g. if we have the following DAGs: client server D draft C draft C draft B draft B public A public A public The current code would only send the phase data for C. The client wouldn't see that B moved from draft to public. This feature will be restored in a future commit. For now, it is making refactoring of how revisions are specified in the wire protocol a bit difficult... Differential Revision: https://phab.mercurial-scm.org/D4978
author Gregory Szorc <gregory.szorc@gmail.com>
date Mon, 08 Oct 2018 17:54:14 -0700
parents a732d70253b0
children 41263df08109
comparison
equal deleted inserted replaced
40174:64360202d5b2 40175:6c42409691ec
424 }, 424 },
425 b'1b74476799ec8318045db759b1b4bcc9b839d0aa\ntest\n0 0\na\n\ncommit 3' 425 b'1b74476799ec8318045db759b1b4bcc9b839d0aa\ntest\n0 0\na\n\ncommit 3'
426 ] 426 ]
427 427
428 Base nodes have just their metadata (e.g. phase) transferred 428 Base nodes have just their metadata (e.g. phase) transferred
429 TODO this doesn't work
429 430
430 $ sendhttpv2peer << EOF 431 $ sendhttpv2peer << EOF
431 > command changesetdata 432 > command changesetdata
432 > fields eval:[b'phase', b'parents', b'revision'] 433 > fields eval:[b'phase', b'parents', b'revision']
433 > noderange eval:[[b'\x33\x90\xef\x85\x00\x73\xfb\xc2\xf0\xdf\xff\x22\x44\x34\x2c\x8e\x92\x29\x01\x3a'], [b'\x0b\xb8\xad\x89\x4a\x15\xb1\x53\x80\xb2\xa2\xa5\xb1\x83\xe2\x0f\x2a\x4b\x28\xdd', b'\xea\xe5\xf8\x2c\x2e\x62\x23\x68\xd2\x7d\xae\xcb\x76\xb7\xe3\x93\xd0\xf2\x42\x11']] 434 > noderange eval:[[b'\x33\x90\xef\x85\x00\x73\xfb\xc2\xf0\xdf\xff\x22\x44\x34\x2c\x8e\x92\x29\x01\x3a'], [b'\x0b\xb8\xad\x89\x4a\x15\xb1\x53\x80\xb2\xa2\xa5\xb1\x83\xe2\x0f\x2a\x4b\x28\xdd', b'\xea\xe5\xf8\x2c\x2e\x62\x23\x68\xd2\x7d\xae\xcb\x76\xb7\xe3\x93\xd0\xf2\x42\x11']]
435 creating http peer for wire protocol version 2 436 creating http peer for wire protocol version 2
436 sending changesetdata command 437 sending changesetdata command
437 response: gen[ 438 response: gen[
438 { 439 {
439 b'totalitems': 3 440 b'totalitems': 3
440 },
441 {
442 b'node': b'3\x90\xef\x85\x00s\xfb\xc2\xf0\xdf\xff"D4,\x8e\x92)\x01:',
443 b'phase': b'public'
444 }, 441 },
445 { 442 {
446 b'fieldsfollowing': [ 443 b'fieldsfollowing': [
447 [ 444 [
448 b'revision', 445 b'revision',