comparison mercurial/crecord.py @ 42659:701341f57ceb stable

curses: do not setlocale() at import time (issue5261)

setlocale() can break date formatting/parsing functions because they are
locale dependent. We should avoid doing setlocale() as possible.

This patch moves setlocale() just before curses.wrapper(), which function
is documented to "initialize curses." I don't know the details about the
curses initialization, but I *think* this would work as well.

Maybe we can extract a curses setup function later.

https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-February/128788.html

42649:7fae3b0bd893

)
from .utils import (
    stringutil,
)
stringio = util.stringio

# This is required for ncurses to display non-ASCII characters in default user
# locale encoding correctly.  --immerrr
locale.setlocale(locale.LC_ALL, r'')

# patch comments based on the git one
diffhelptext = _("""# To remove '-' lines, make them ' ' lines (context).
# To remove '+' lines, delete them.
# Lines starting with # will be removed from the patch.

    curses interface to get selection of chunks, and mark the applied flags
    of the chosen chunks.
    """
    ui.write(_('starting interactive selection\n'))
    chunkselector = curseschunkselector(headerlist, ui, operation)
    origsigtstp = sentinel = object()
    if util.safehasattr(signal, 'SIGTSTP'):
        origsigtstp = signal.getsignal(signal.SIGTSTP)
    try:
        curses.wrapper(chunkselector.main)

42659:701341f57ceb

)
from .utils import (
    stringutil,
)
stringio = util.stringio

# patch comments based on the git one
diffhelptext = _("""# To remove '-' lines, make them ' ' lines (context).
# To remove '+' lines, delete them.
# Lines starting with # will be removed from the patch.

    curses interface to get selection of chunks, and mark the applied flags
    of the chosen chunks.
    """
    ui.write(_('starting interactive selection\n'))
    chunkselector = curseschunkselector(headerlist, ui, operation)
    # This is required for ncurses to display non-ASCII characters in
    # default user locale encoding correctly.  --immerrr
    locale.setlocale(locale.LC_ALL, r'')
    origsigtstp = sentinel = object()
    if util.safehasattr(signal, 'SIGTSTP'):
        origsigtstp = signal.getsignal(signal.SIGTSTP)
    try:
        curses.wrapper(chunkselector.main)