comparison mercurial/wireprotov2server.py @ 46697:71443f742886 stable

wireprotoserver: convert ErrorResponse to bytes

Caught by pytype:

     File "/mnt/c/Users/Matt/hg/mercurial/wireprotoserver.py", line 236, in handlewsgirequest: Function _bytestr.__init__ was called with the wrong arguments [wrong-arg-types]
              Expected: (self, ints: Iterable[int])
       Actually passed: (self, ints: mercurial.hgweb.common.ErrorResponse)
       The following methods aren't implemented on mercurial.hgweb.common.ErrorResponse:
       __iter__
     File "/mnt/c/Users/Matt/hg/mercurial/wireprotoserver.py", line 239, in handlewsgirequest: Function _bytestr.__init__ was called with the wrong arguments [wrong-arg-types]
              Expected: (self, ints: Iterable[int])
       Actually passed: (self, ints: mercurial.hgweb.common.ErrorResponse)
       The following methods aren't implemented on mercurial.hgweb.common.ErrorResponse:
       __iter__
     File "/mnt/c/Users/Matt/hg/mercurial/wireprotov2server.py", line 91, in handlehttpv2request: Function _bytestr.__init__ was called with the wrong arguments [wrong-arg-types]
              Expected: (self, ints: Iterable[int])
       Actually passed: (self, ints: mercurial.hgweb.common.ErrorResponse)
       The following methods aren't implemented on mercurial.hgweb.common.ErrorResponse:
       __iter__

Differential Revision: https://phab.mercurial-scm.org/D10182

46696:ed0899e01628

    # TODO return reasonable responses - not responses that overload the
    # HTTP status line message for error reporting.
    try:
        checkperm(rctx, req, b'pull' if permission == b'ro' else b'push')
    except hgwebcommon.ErrorResponse as e:
        res.status = hgwebcommon.statusmessage(e.code, pycompat.bytestr(e))
        for k, v in e.headers:
            res.headers[k] = v
        res.setbodybytes(b'permission denied')
        return

46697:71443f742886

    # TODO return reasonable responses - not responses that overload the
    # HTTP status line message for error reporting.
    try:
        checkperm(rctx, req, b'pull' if permission == b'ro' else b'push')
    except hgwebcommon.ErrorResponse as e:
        res.status = hgwebcommon.statusmessage(
            e.code, stringutil.forcebytestr(e)
        )
        for k, v in e.headers:
            res.headers[k] = v
        res.setbodybytes(b'permission denied')
        return