comparison hgext/rebase.py @ 43934:71fee4564410

rebase: use rewriteutil.precheck() instead of reimplementing it

After this patch, there's still another place in `rebase.py`, in the
`--stop` code path, that reimplements `rewriteutil.precheck()`. I
couldn't fix that place because it `rewriteutil.precheck()` checks
that there is only one dirstate parent, which fails because we have
two parents at that point. I think it's incorrect that rebase leaves
the user with two parents during conflicts, but changing that is way
out of scope for this series.

Differential Revision: https://phab.mercurial-scm.org/D7685

43933:bde97bee321f

    pycompat,
    registrar,
    repair,
    revset,
    revsetlang,
    scmutil,
    smartset,
    state as statemod,
    util,
)

    def _preparenewrebase(self, destmap):
        if not destmap:
            return _nothingtorebase()

        rebaseset = destmap.keys()
        allowunstable = obsolete.isenabled(self.repo, obsolete.allowunstableopt)
        if not (self.keepf or allowunstable) and self.repo.revs(
            b'first(children(%ld) - %ld)', rebaseset, rebaseset
        ):
            raise error.Abort(
                _(
                    b"can't remove original changesets with"
                    b" unrebased descendants"
                ),
                hint=_(b'use --keep to keep original changesets'),
            )

        result = buildstate(self.repo, destmap, self.collapsef)

        if not result:
            # Empty state built, nothing to rebase
            self.ui.status(_(b'nothing to rebase\n'))
            return _nothingtorebase()

        for root in self.repo.set(b'roots(%ld)', rebaseset):
            if not self.keepf and not root.mutable():
                raise error.Abort(
                    _(b"can't rebase public changeset %s") % root,
                    hint=_(b"see 'hg help phases' for details"),
                )

        (self.originalwd, self.destmap, self.state) = result
        if self.collapsef:
            dests = set(self.destmap.values())
            if len(dests) != 1:

43934:71fee4564410

    pycompat,
    registrar,
    repair,
    revset,
    revsetlang,
    rewriteutil,
    scmutil,
    smartset,
    state as statemod,
    util,
)

    def _preparenewrebase(self, destmap):
        if not destmap:
            return _nothingtorebase()

        rebaseset = destmap.keys()
        if not self.keepf:
            try:
                rewriteutil.precheck(self.repo, rebaseset, action=b'rebase')
            except error.Abort as e:
                if e.hint is None:
                    e.hint = b'use --keep to keep original changesets'
                raise e

        result = buildstate(self.repo, destmap, self.collapsef)

        if not result:
            # Empty state built, nothing to rebase
            self.ui.status(_(b'nothing to rebase\n'))
            return _nothingtorebase()

        (self.originalwd, self.destmap, self.state) = result
        if self.collapsef:
            dests = set(self.destmap.values())
            if len(dests) != 1: