Mercurial > hg
comparison mercurial/hook.py @ 46492:7289eac777ec stable
hooks: introduce a `:run-with-plain` option for hooks
This option control if HGPLAIN should be set or not for the hooks. This is the
first step to give user some control of the HGPLAIN setting for they hooks.
Some hooks (eg: consistency checking) deserve to be run with HGPLAIN, some other
(eg: user set visual helper) might need to respect the user config and setting.
So both usage are valid and we need to restore the ability to run -without-
HGPLAIN that got lost in Mercurial 5.7.
This does not offer a way to restore the pre-5.7 behavior yet (respect whatever
HGPLAIN setting from the shell), this will be dealt with in the next changeset.
The option name is a bit verbose because implementing this highlighs the need
for another option: `:run-if-plain`. That would make it possible for some hooks
to be easily disabled if HG PLAIN is set. However such option would be a new
feature, not something introduced to mitigate a behavior change introduced in
5.7, so the `:run-if-plain` option belong to the default branch and is not part
of this series.
Differential Revision: https://phab.mercurial-scm.org/D9981
author | Pierre-Yves David <pierre-yves.david@octobus.net> |
---|---|
date | Wed, 10 Feb 2021 23:21:21 +0100 |
parents | 86b019899737 |
children | b910be772eb9 |
comparison
equal
deleted
inserted
replaced
46491:0760282995cf | 46492:7289eac777ec |
---|---|
155 repo.dirstate.write(tr) | 155 repo.dirstate.write(tr) |
156 if tr and tr.writepending(): | 156 if tr and tr.writepending(): |
157 env[b'HG_PENDING'] = repo.root | 157 env[b'HG_PENDING'] = repo.root |
158 env[b'HG_HOOKTYPE'] = htype | 158 env[b'HG_HOOKTYPE'] = htype |
159 env[b'HG_HOOKNAME'] = name | 159 env[b'HG_HOOKNAME'] = name |
160 env[b'HGPLAIN'] = b'1' | 160 |
161 plain = ui.configbool(b'hooks', b'%s:run-with-plain' % name) | |
162 if plain: | |
163 env[b'HGPLAIN'] = b'1' | |
164 else: | |
165 env[b'HGPLAIN'] = b'' | |
161 | 166 |
162 for k, v in pycompat.iteritems(args): | 167 for k, v in pycompat.iteritems(args): |
163 # transaction changes can accumulate MBs of data, so skip it | 168 # transaction changes can accumulate MBs of data, so skip it |
164 # for external hooks | 169 # for external hooks |
165 if k == b'changes': | 170 if k == b'changes': |