comparison mercurial/repository.py @ 39872:733db72f0f54

revlog: move revision verification out of verify

File revision verification is performing low-level checks of file
storage, namely that flags are appropriate and revision data can
be resolved.

Since these checks are somewhat revlog-specific and may not
be appropriate for alternate storage backends, this commit moves
those checks from verify.py to revlog.py.

Because we're now emitting warnings/errors that apply to specific
revisions, we taught the iverifyproblem interface to expose the
problematic node and to report this node in verify output. This
was necessary to prevent unwanted test changes.

After this change, revlog.verifyintegrity() and file verify code
in verify.py both iterate over revisions and resolve their fulltext.
But they do so in separate loops. (verify.py needs to resolve
fulltexts as part of calling renamed() - at least when using revlogs.)
This should add overhead.

But on the mozilla-unified repo:

$ hg verify
before: time: real 700.640 secs (user 585.520+0.000 sys 23.480+0.000)
after:  time: real 682.380 secs (user 570.370+0.000 sys 22.240+0.000)

I'm not sure what's going on. Maybe avoiding the filelog attribute
proxies shaved off enough time to offset the losses? Maybe fulltext
resolution has less overhead than I thought?

I've left a comment indicating the potential for optimization. But
because it doesn't produce a performance regression on a large
repository, I'm not going to worry about it.

Differential Revision: https://phab.mercurial-scm.org/D4745

39871:01c0f01b562b

    warning = interfaceutil.Attribute(
        """Message indicating a non-fatal problem.""")

    error = interfaceutil.Attribute(
        """Message indicating a fatal problem.""")

class irevisiondelta(interfaceutil.Interface):
    """Represents a delta between one revision and another.

    Instances convey enough information to allow a revision to be exchanged

        ``state`` is a dict holding state of the verifier process. It can be
        used to communicate data between invocations of multiple storage
        primitives.

        The method yields objects conforming to the ``iverifyproblem``
        interface.
        """

class idirs(interfaceutil.Interface):

39872:733db72f0f54

    warning = interfaceutil.Attribute(
        """Message indicating a non-fatal problem.""")

    error = interfaceutil.Attribute(
        """Message indicating a fatal problem.""")

    node = interfaceutil.Attribute(
        """Revision encountering the problem.

        ``None`` means the problem doesn't apply to a single revision.
        """)

class irevisiondelta(interfaceutil.Interface):
    """Represents a delta between one revision and another.

    Instances convey enough information to allow a revision to be exchanged

        ``state`` is a dict holding state of the verifier process. It can be
        used to communicate data between invocations of multiple storage
        primitives.

        If individual revisions cannot have their revision content resolved,
        the method is expected to set the ``skipread`` key to a set of nodes
        that encountered problems.

        The method yields objects conforming to the ``iverifyproblem``
        interface.
        """

class idirs(interfaceutil.Interface):